Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: src/runtime/runtime-internal.cc

Issue 1618343002: [interpreter, debugger] abstraction for source position calculation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove bogus assertion Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime-generator.cc ('k') | test/mjsunit/ignition/stack-trace-source-position.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/ast/prettyprinter.h" 8 #include "src/ast/prettyprinter.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/conversions.h" 10 #include "src/conversions.h"
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 Object* script = fun->shared()->script(); 388 Object* script = fun->shared()->script();
389 if (script->IsScript() && 389 if (script->IsScript() &&
390 !(Script::cast(script)->source()->IsUndefined())) { 390 !(Script::cast(script)->source()->IsUndefined())) {
391 Handle<Script> casted_script(Script::cast(script)); 391 Handle<Script> casted_script(Script::cast(script));
392 // Compute the location from the function and the relocation info of the 392 // Compute the location from the function and the relocation info of the
393 // baseline code. For optimized code this will use the deoptimization 393 // baseline code. For optimized code this will use the deoptimization
394 // information to get canonical location information. 394 // information to get canonical location information.
395 List<FrameSummary> frames(FLAG_max_inlining_levels + 1); 395 List<FrameSummary> frames(FLAG_max_inlining_levels + 1);
396 it.frame()->Summarize(&frames); 396 it.frame()->Summarize(&frames);
397 FrameSummary& summary = frames.last(); 397 FrameSummary& summary = frames.last();
398 int pos = summary.code()->SourcePosition(summary.pc()); 398 int pos = summary.abstract_code()->SourcePosition(summary.code_offset());
399 *target = MessageLocation(casted_script, pos, pos + 1, handle(fun)); 399 *target = MessageLocation(casted_script, pos, pos + 1, handle(fun));
400 return true; 400 return true;
401 } 401 }
402 } 402 }
403 return false; 403 return false;
404 } 404 }
405 405
406 406
407 Handle<String> RenderCallSite(Isolate* isolate, Handle<Object> object) { 407 Handle<String> RenderCallSite(Isolate* isolate, Handle<Object> object) {
408 MessageLocation location; 408 MessageLocation location;
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
484 std::stringstream stats_stream; 484 std::stringstream stats_stream;
485 isolate->runtime_state()->runtime_call_stats()->Print(stats_stream); 485 isolate->runtime_state()->runtime_call_stats()->Print(stats_stream);
486 Handle<String> result = 486 Handle<String> result =
487 isolate->factory()->NewStringFromAsciiChecked(stats_stream.str().c_str()); 487 isolate->factory()->NewStringFromAsciiChecked(stats_stream.str().c_str());
488 isolate->runtime_state()->runtime_call_stats()->Reset(); 488 isolate->runtime_state()->runtime_call_stats()->Reset();
489 return *result; 489 return *result;
490 } 490 }
491 491
492 } // namespace internal 492 } // namespace internal
493 } // namespace v8 493 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime-generator.cc ('k') | test/mjsunit/ignition/stack-trace-source-position.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698