device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java - Issue 1618273002: Call BluetoothGatt#close() after disconnecting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java

Issue 1618273002: Call BluetoothGatt#close() after disconnecting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call parent class' TearDown Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java ('k') | device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java

diff --git a/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java b/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java

index ef1fd84de82d2e90bd4f5dac9c3128857ede198f..ea0a4dc75e16e83aa2bac105c6d28a49cfb069e8 100644

--- a/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java

+++ b/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java

@@ -54,7 +54,9 @@ final class ChromeBluetoothRemoteGattCharacteristic {

@CalledByNative

private void onBluetoothRemoteGattCharacteristicAndroidDestruction() {

Log.v(TAG, "ChromeBluetoothRemoteGattCharacteristic Destroyed.");

- mChromeDevice.mBluetoothGatt.setCharacteristicNotification(mCharacteristic, false);

+ if (mChromeDevice.mBluetoothGatt != null) {

+ mChromeDevice.mBluetoothGatt.setCharacteristicNotification(mCharacteristic, false);

+ }

mNativeBluetoothRemoteGattCharacteristicAndroid = 0;

mChromeDevice.mWrapperToChromeCharacteristicsMap.remove(mCharacteristic);

}