Chromium Code Reviews| Index: build/android/gyp/util/build_utils.py |
| diff --git a/build/android/gyp/util/build_utils.py b/build/android/gyp/util/build_utils.py |
| index fe69c956f0f9f49db1ceb4e085c84668e1c7a5fc..c601e06d7157fd97855749a8ecd781c22aac590f 100644 |
| --- a/build/android/gyp/util/build_utils.py |
| +++ b/build/android/gyp/util/build_utils.py |
| @@ -77,6 +77,17 @@ def FindInDirectories(directories, filename_filter): |
| def ParseGnList(gn_string): |
| + # TODO(brettw) bug 573132: This doesn't handle GN escaping properly, so any |
| + # weird characters like $ or \ in the strings will be corrupted. |
| + # |
| + # The code should import build/gn_helpers.py and then do: |
| + # parser = gn_helpers.GNValueParser(gn_string) |
| + # return return parser.ParseList() |
| + # As of this writing, though, there is a CastShell build script that sends |
| + # JSON through this function, and using correct GN parsing corrupts that. |
| + # |
| + # We need to be consistent about passing either JSON or GN lists through |
| + # this function. |
|
Dirk Pranke
2016/01/29 21:01:56
ick. I suppose fixing the CastShell is part of thi
brettw
2016/01/29 21:10:21
I started doing this and got super confused. The A
Dirk Pranke
2016/01/29 21:38:42
Okay, maybe slan@ can help us get that part straig
slan
2016/01/29 22:37:56
Sure. Brett, to which script are you referring?
|
| return ast.literal_eval(gn_string) |