device/hid/hid_connection.cc - Issue 161823002: Clean up HID backend and API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/hid/hid_connection.cc

Issue 161823002: Clean up HID backend and API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Many cleanup, such device ID, woww. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "device/hid/hid_connection.h"	5 #include "device/hid/hid_connection.h"

6	6

7 namespace device {	7 namespace device {

8	8

9 HidConnection::HidConnection(HidDeviceInfo device_info)	9 PendingHidReport::PendingHidReport() {}

	10

	11 PendingHidReport::~PendingHidReport() {}

	12

	13 PendingHidRead::PendingHidRead() {}

	14

	15 PendingHidRead::~PendingHidRead() {}

	16

	17 HidConnection::HidConnection(const HidDeviceInfo& device_info)

10 : device_info_(device_info) {}	18 : device_info_(device_info) {}

11	19

12 HidConnection::~HidConnection() {}	20 HidConnection::~HidConnection() {}

13	21

14 const HidDeviceInfo& HidConnection::device_info() const {	22 const HidDeviceInfo& HidConnection::device_info() const {

15 return device_info_;	23 return device_info_;
	Mark Mentovai 2014/02/21 17:48:18 It’s OK to write this simple accessor inline in th It’s OK to write this simple accessor inline in the header. Ken Rockot(use gerrit already) 2014/02/22 01:17:04 Done. Show quoted text On 2014/02/21 17:48:18, Mark Mentovai wrote: > It’s OK to write this simple accessor inline in the header. Done.
16 }	24 }

17	25

18 } // namespace device	26 } // namespace device

OLD	NEW