Clean up HID backend and API.

device/hid/hid_service_linux.cc

-// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <libudev.h>
+#include <stdint.h>
 #include <string>
 #include <vector>
 
-#include "base/basictypes.h"
-#include "base/bind.h"
-#include "base/callback.h"
 #include "base/logging.h"
-#include "base/memory/scoped_vector.h"
 #include "base/platform_file.h"
+#include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_split.h"
-#include "base/threading/thread_restrictions.h"
-#include "device/hid/hid_connection.h"
 #include "device/hid/hid_connection_linux.h"
 #include "device/hid/hid_device_info.h"
 #include "device/hid/hid_service_linux.h"
 
 namespace device {
 
 namespace {
 
 const char kUdevName[] = "udev";
 const char kUdevActionAdd[] = "add";
@@ skipping 73 matching lines @@
     return;
   }
 
   // This list is managed by |enumerate|.
   udev_list_entry* devices = udev_enumerate_get_list_entry(enumerate.get());
   for (udev_list_entry* i = devices; i != NULL;
       i = udev_list_entry_get_next(i)) {
     ScopedUdevDevicePtr hid_dev(
         udev_device_new_from_syspath(udev_.get(), udev_list_entry_get_name(i)));
     if (hid_dev) {
-      PlatformDeviceAdd(hid_dev.get());
+      PlatformAddDevice(hid_dev.get());
     }
   }
-
-  initialized_ = true;
 }
 
-void HidServiceLinux::PlatformDeviceAdd(udev_device* device) {
+void HidServiceLinux::PlatformAddDevice(udev_device* device) {
   if (!device)
     return;
 
   const char* device_id = udev_device_get_syspath(device);
   if (!device_id)
     return;
 
 
   HidDeviceInfo device_info;
   device_info.device_id = device_id;
 
-  uint32 int_property = 0;
+  uint32_t int_property = 0;
   const char* str_property = NULL;
 
   const char* hid_id = udev_device_get_property_value(device, kHIDID);
   if (!hid_id)
     return;
 
   std::vector<std::string> parts;
   base::SplitString(hid_id, ':', &parts);
   if (parts.size() != 3) {
     return;
@@ skipping 11 matching lines @@
   if (str_property != NULL)
     device_info.serial_number = str_property;
 
   str_property = udev_device_get_property_value(device, kHIDName);
   if (str_property != NULL)
     device_info.product_name = str_property;
 
   AddDevice(device_info);
 }
 
-void HidServiceLinux::PlatformDeviceRemove(udev_device* raw_dev) {
+void HidServiceLinux::PlatformRemoveDevice(udev_device* raw_dev) {
   // The returned the device is not referenced.
   udev_device* hid_dev =
       udev_device_get_parent_with_subsystem_devtype(raw_dev, "hid", NULL);
 
   if (!hid_dev)
     return;
 
   const char* device_id = NULL;
   device_id = udev_device_get_syspath(hid_dev);
   if (device_id == NULL)
     return;
 
   RemoveDevice(device_id);
 }
 
-scoped_refptr<HidConnection> HidServiceLinux::Connect(std::string device_id) {
+scoped_refptr<HidConnection> HidServiceLinux::Connect(
+    const std::string& device_id) {
   if (!ContainsKey(devices_, device_id))
     return NULL;
   ScopedUdevDevicePtr hid_device(
       udev_device_new_from_syspath(udev_.get(), device_id.c_str()));
   if (hid_device) {
     scoped_refptr<HidConnectionLinux> connection =
         new HidConnectionLinux(devices_[device_id], hid_device.Pass());
     if (connection->initialized())
       return connection;
   }
   return NULL;
 }
 
 void HidServiceLinux::OnFileCanReadWithoutBlocking(int fd) {
   DCHECK_EQ(monitor_fd_, fd);
 
   ScopedUdevDevicePtr dev(udev_monitor_receive_device(monitor_.get()));
   if (!dev)
     return;
 
   std::string action(udev_device_get_action(dev.get()));
   if (action == kUdevActionAdd) {
-    PlatformDeviceAdd(dev.get());
+    PlatformAddDevice(dev.get());
   } else if (action == kUdevActionRemove) {
-    PlatformDeviceRemove(dev.get());
+    PlatformRemoveDevice(dev.get());
   }
 }
 
 void HidServiceLinux::OnFileCanWriteWithoutBlocking(int fd) {}
 
 } // namespace dev