Issue 16182002: Relanding "chrome/browser: Remove unnecessary entries from DEPS files."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16182002: Relanding "chrome/browser: Remove unnecessary entries from DEPS files." (Closed)

Created:
7 years, 6 months ago by tfarina

Modified:
7 years, 6 months ago

Reviewers:
Lei Zhang, Jói

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Relanding "chrome/browser: Remove unnecessary entries from DEPS files." After recent refactorings chrome/browser/api and a few chrome/browser/profiles/ includes are not necessary anymore. c/b/api was removed in r195919 by Peter and some c/b/profiles/ were moved in r201167 by Pawel. BUG=138280, 144783, 140037, 144050, 146851, 233552 TEST=checkdeps.py passes. TBR=joi@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202752

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -11 lines)			Patch
M	WATCHLISTS	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/common/DEPS	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/common/README	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/favicon/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/history/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/browser/DEPS	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

tfarina

Relanding + TBR. Fix is in patch set 2 (I accidentally removed 'filepath' :/, shrug).

7 years, 6 months ago (2013-05-29 02:41:10 UTC) #1

tfarina

Committed patchset #2 manually as r202752 (presubmit successful).

7 years, 6 months ago (2013-05-29 02:41:35 UTC) #2

Jói

7 years, 6 months ago (2013-05-29 10:54:11 UTC) #4

LGTM

On Wed, May 29, 2013 at 3:47 AM,  <thestig@chromium.org> wrote:
> lgtm
>
> https://codereview.chromium.org/16182002/