arc: Pass auth token from Chrome to ARC instance.

chrome/browser/chromeos/arc/arc_auth_service_unittest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+#include <vector>
+
+#include "base/bind.h"
+#include "base/files/file_path.h"
+#include "base/files/file_util.h"
+#include "base/files/scoped_temp_dir.h"
+#include "base/macros.h"
+#include "base/run_loop.h"
+#include "chrome/browser/chromeos/arc/arc_auth_fetcher.h"
+#include "chrome/browser/chromeos/arc/arc_auth_service.h"
+#include "chrome/test/base/testing_profile.h"
+#include "components/arc/arc_bridge_service.h"
+#include "components/arc/test/fake_arc_bridge_service.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "google_apis/gaia/gaia_constants.h"
+#include "google_apis/gaia/gaia_urls.h"
+#include "net/http/http_status_code.h"
+#include "net/url_request/test_url_fetcher_factory.h"
+#include "net/url_request/url_fetcher.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace arc {
+
+namespace {
+
+const int kThreadOptions = content::TestBrowserThreadBundle::IO_MAINLOOP;
+const char kTestAuthCode[] = "4/Qa3CPIhh-WcMfWSf9HZaYcGUhEeax-F9sQK9CNRhZWs";
+
+scoped_ptr<TestingProfile> CreateProfile() {
+  base::ScopedTempDir temp_dir;

[xiyuan, 2016/01/26 23:37:05]

ScopedTempDir would auto delete the temp dir when it goes out of scope. We
should not be using it like this because the returned TestingProfile might still
need access to the dir.

[khmel, 2016/01/27 22:36:21]

Yes, overlooked this. Thanks.

+  EXPECT_TRUE(temp_dir.CreateUniqueTempDir());
+  base::FilePath path = temp_dir.path().AppendASCII("TestArcProfile");
+  EXPECT_TRUE(base::DeleteFile(path, true));
+  EXPECT_TRUE(base::CreateDirectory(path));
+
+  TestingProfile::Builder profile_builder;
+  profile_builder.SetPath(path);
+  return profile_builder.Build();
+}
+
+}  // namespace
+
+class ArcAuthServiceTest : public testing::Test {
+ public:
+  ArcAuthServiceTest()
+      : thread_bundle_(new content::TestBrowserThreadBundle(kThreadOptions)),
+        url_fetcher_factory_(
+            nullptr,
+            base::Bind(&ArcAuthServiceTest::FakeURLFetcherCreator,
+                       base::Unretained(this))) {}
+  ~ArcAuthServiceTest() override {}
+
+  void SetUp() override {
+    ArcAuthService::DisableUIForTesting();
+    profile_ = CreateProfile();
+    bridge_service_.reset(new FakeArcBridgeService());
+    auth_service_.reset(new ArcAuthService(bridge_service_.get()));
+
+    // Check initial conditions.
+    EXPECT_EQ(bridge_service_.get(), ArcBridgeService::Get());
+    EXPECT_EQ(true, !ArcBridgeService::Get()->available());
+    EXPECT_EQ(ArcBridgeService::State::STOPPED,
+              ArcBridgeService::Get()->state());
+  }
+
+  void TearDown() override {}
+
+ protected:
+  Profile* profile() { return profile_.get(); }
+  FakeArcBridgeService* bridge_service() { return bridge_service_.get(); }
+  ArcAuthService* auth_service() { return auth_service_.get(); }
+  net::FakeURLFetcherFactory& url_fetcher_factory() {
+    return url_fetcher_factory_;
+  }
+  void set_cookie(const std::string& cookie) { rt_cookie_ = cookie; }
+
+ private:
+  scoped_ptr<content::TestBrowserThreadBundle> thread_bundle_;
+  net::FakeURLFetcherFactory url_fetcher_factory_;
+  scoped_ptr<arc::FakeArcBridgeService> bridge_service_;
+  scoped_ptr<arc::ArcAuthService> auth_service_;
+  scoped_ptr<TestingProfile> profile_;
+  std::string rt_cookie_;

[xiyuan, 2016/01/26 23:37:05]

Data bembers are always declared last, i.e. move these after
FakeURLFetcherCreator().

[khmel, 2016/01/27 22:36:21]

Done.

+
+  scoped_ptr<net::FakeURLFetcher> FakeURLFetcherCreator(
+      const GURL& url,
+      net::URLFetcherDelegate* delegate,
+      const std::string& response_data,
+      net::HttpStatusCode response_code,
+      net::URLRequestStatus::Status status) {
+    scoped_ptr<net::FakeURLFetcher> fetcher(new net::FakeURLFetcher(
+        url, delegate, response_data, response_code, status));
+    // Use cookie only once.
+    if (!rt_cookie_.empty()) {
+      net::ResponseCookies cookies;
+      cookies.push_back(rt_cookie_);
+      fetcher->set_cookies(cookies);
+      rt_cookie_ = "";
+    }
+    return fetcher;
+  }
+
+  DISALLOW_COPY_AND_ASSIGN(ArcAuthServiceTest);
+};
+
+TEST_F(ArcAuthServiceTest, Workflow) {
+  ASSERT_EQ(ArcBridgeService::State::STOPPED, bridge_service()->state());
+  ASSERT_EQ(ArcAuthService::State::DISABLE, auth_service()->state());
+  ASSERT_EQ("", auth_service()->GetAuthCode());
+
+  const GURL gaia_gurl = ArcAuthFetcher::CreateURL(profile());
+  url_fetcher_factory().SetFakeResponse(gaia_gurl, "", net::HTTP_OK,
+                                        net::URLRequestStatus::SUCCESS);
+  std::string cookie = "oauth_code=";
+  cookie += kTestAuthCode;
+  cookie += "; Path=/o/oauth2/programmatic_auth; Secure; HttpOnly";
+  set_cookie(cookie);
+  auth_service()->SetProfile(profile());
+
+  // Setting profile initiates a code fetching process.
+  ASSERT_EQ(ArcAuthService::State::FETCHING_CODE, auth_service()->state());
+
+  content::BrowserThread::GetBlockingPool()->FlushForTesting();
+  base::RunLoop().RunUntilIdle();
+
+  ASSERT_EQ(ArcAuthService::State::ENABLE, auth_service()->state());
+  ASSERT_EQ(ArcBridgeService::State::READY, bridge_service()->state());
+  // Auth tolen valid only for one call.
+  ASSERT_EQ(kTestAuthCode, auth_service()->GetAuthCode());
+  ASSERT_EQ("", auth_service()->GetAuthCode());
+
+  // Empty profile disables opt-in.
+  auth_service()->SetProfile(nullptr);
+  ASSERT_EQ(ArcAuthService::State::DISABLE, auth_service()->state());
+  ASSERT_EQ(ArcBridgeService::State::STOPPED, bridge_service()->state());
+  ASSERT_EQ("", auth_service()->GetAuthCode());
+
+  // Send profile and don't provide a code.
+  auth_service()->SetProfile(profile());
+
+  // Setting profile initiates a code fetching process.
+  ASSERT_EQ(ArcAuthService::State::FETCHING_CODE, auth_service()->state());
+
+  content::BrowserThread::GetBlockingPool()->FlushForTesting();
+  base::RunLoop().RunUntilIdle();
+
+  // UI is disabled in unit tests and this code is unchanged.
+  ASSERT_EQ(ArcAuthService::State::FETCHING_CODE, auth_service()->state());
+
+  // Send error response.
+  url_fetcher_factory().SetFakeResponse(gaia_gurl, "", net::HTTP_BAD_REQUEST,
+                                        net::URLRequestStatus::SUCCESS);
+  auth_service()->SetProfile(nullptr);
+  ASSERT_EQ(ArcAuthService::State::DISABLE, auth_service()->state());
+  auth_service()->SetProfile(profile());
+
+  ASSERT_EQ(ArcAuthService::State::FETCHING_CODE, auth_service()->state());
+  content::BrowserThread::GetBlockingPool()->FlushForTesting();
+  base::RunLoop().RunUntilIdle();
+
+  ASSERT_EQ(ArcAuthService::State::NO_CODE, auth_service()->state());
+}
+
+}  // namespace arc