extensions/common/manifest_constants.cc - Issue 1618073002: Extensions - Check for too big or too small product icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_constants.cc

Issue 1618073002: Extensions - Check for too big or too small product icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/manifest_constants.cc

diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc

index d9481702167bdb1bbd2f782dc6860c263e16764a..7195ddad38b41d7e9f51c37be86c2659805302da 100644

--- a/extensions/common/manifest_constants.cc

+++ b/extensions/common/manifest_constants.cc

@@ -406,6 +406,7 @@ const char kInvalidHomepageOverrideURL[] =

"Invalid value for overriding homepage url: '[*]'.";

const char kInvalidHomepageURL[] =

"Invalid value for homepage url: '[*]'.";

+const char kInvalidIconKey[] = "Invalid key in icons: \"*\".";

const char kInvalidIconPath[] =

"Invalid value for 'icons[\"*\"]'.";

const char kInvalidIcons[] =

« no previous file with comments | « extensions/common/manifest_constants.h ('k') | extensions/common/manifest_handler_helpers.cc » ('j') | no next file with comments »