Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 161803002: Remove Non-Aura Win ShowMessageBox. (Closed)

Created:
6 years, 10 months ago by msw
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Remove Non-Aura Win ShowMessageBox. BUG=330735 TEST=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M chrome/browser/ui/views/simple_message_box_win.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
msw
Hey Scott, please take a look; thanks! (I may consolidate some related files next)
6 years, 10 months ago (2014-02-12 22:56:02 UTC) #1
sky
LGTM
6 years, 10 months ago (2014-02-12 23:37:00 UTC) #2
msw
The CQ bit was checked by msw@chromium.org
6 years, 10 months ago (2014-02-12 23:48:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/161803002/1
6 years, 10 months ago (2014-02-12 23:50:54 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 00:23:33 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=226055
6 years, 10 months ago (2014-02-13 00:23:33 UTC) #6
msw
The CQ bit was checked by msw@chromium.org
6 years, 10 months ago (2014-02-13 00:33:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/161803002/1
6 years, 10 months ago (2014-02-13 00:34:41 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 04:21:38 UTC) #9
Message was sent while issue was closed. 
Change committed as 250942

Powered by Google App Engine
This is Rietveld 408576698