Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 16180009: Improve WebValidationMessageClient interface and implementation. (Closed)

Created:
7 years, 6 months ago by tkent
Modified:
7 years, 6 months ago
Reviewers:
keishi
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Improve WebValidationMessageClient interface and implementation. * Change the anchor position argument of showValidationMessage from the screen coordinate system to the root view coordinate system. Blink can't provide a rectangle in the screen coordinate on Android port because HostWindow::rootViewToScreen does nothing on Android, and we'd like to make it consistent. This change breaks validation message bubble position temporarily until UI implementations for non-Android is updated. * Add moveValidationMessage to avoid recreation of UI widgets. * Take account of the length of title attribute value for display duration. BUG=146212 R=keishi@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152176

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M Source/WebKit/chromium/src/ValidationMessageClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/ValidationMessageClientImpl.cpp View 2 chunks +8 lines, -10 lines 0 comments Download
M public/webpage/WebValidationMessageClient.h View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tkent
Would you review this please? This shouldn't landed until https://codereview.chromium.org/16583005/ is ready.
7 years, 6 months ago (2013-06-07 05:13:32 UTC) #1
tkent
This is ready. Keishi, would you review this please?
7 years, 6 months ago (2013-06-10 22:27:11 UTC) #2
keishi
lgtm
7 years, 6 months ago (2013-06-11 02:25:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/16180009/1
7 years, 6 months ago (2013-06-11 02:29:41 UTC) #4
commit-bot: I haz the power
Failed to apply patch for public/webview/WebValidationMessageClient.h: While running patch -p1 --forward --force --no-backup-if-mismatch; A public/webview ...
7 years, 6 months ago (2013-06-11 02:29:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/16180009/9001
7 years, 6 months ago (2013-06-11 02:33:31 UTC) #6
tkent
7 years, 6 months ago (2013-06-11 03:19:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r152176 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698