Chromium Code Reviews
DescriptionImprove WebValidationMessageClient interface and implementation.
* Change the anchor position argument of showValidationMessage from the
screen coordinate system to the root view coordinate system. Blink
can't provide a rectangle in the screen coordinate on Android port
because HostWindow::rootViewToScreen does nothing on Android, and
we'd like to make it consistent. This change breaks validation message
bubble position temporarily until UI implementations for non-Android is
updated.
* Add moveValidationMessage to avoid recreation of UI widgets.
* Take account of the length of title attribute value for display duration.
BUG=146212
R=keishi@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152176
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 7 (0 generated)
|
|||||||||||||||||||||||||||||||||||||