Issue 1618: Makes new tab page update properly when its told bookmarks are...

Issue 1618: Makes new tab page update properly when its told bookmarks are... (Closed)

Created:
12 years, 3 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy, Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Makes new tab page update properly when its told bookmarks are changed. BUG=1861 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1845

Patch Set 2 : '' #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	chrome/browser/resources/new_tab.html	View	1	3 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/1618/diff/1/2 File chrome/browser/resources/new_tab.html (right): http://codereview.chromium.org/1618/diff/1/2#newcode547 Line 547: while(container.hasChildNodes()) { Better than this loop: container.innerHTML = ...

12 years, 3 months ago (2008-09-08 16:13:46 UTC) #2

Glen Murphy

12 years, 3 months ago (2008-09-08 16:27:13 UTC) #3

LGTM

Expand Messages | Collapse Messages