content/browser/renderer_host/web_input_event_aura_unittest.cc - Issue 1617863002: Set the correct pressure for pointer events based on force

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/web_input_event_aura_unittest.cc

Issue 1617863002: Set the correct pressure for pointer events based on force (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/web_input_event_aura.cc ('K') | « content/browser/renderer_host/web_input_event_aura.cc ('k') | third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html » ('j') | ui/events/test/event_generator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/web_input_event_aura_unittest.cc

diff --git a/content/browser/renderer_host/web_input_event_aura_unittest.cc b/content/browser/renderer_host/web_input_event_aura_unittest.cc

index 2d46dfb2e4070d9a073950db725463106e370c00..263a239508274fd40e7f3abcfecb928c75585507 100644

--- a/content/browser/renderer_host/web_input_event_aura_unittest.cc

+++ b/content/browser/renderer_host/web_input_event_aura_unittest.cc

@@ -425,7 +425,7 @@ TEST(WebInputEventAuraTest, TestMakeWebMouseEvent) {

webkit_event.pointerType);

EXPECT_EQ(0, webkit_event.tiltX);

EXPECT_EQ(0, webkit_event.tiltY);

- EXPECT_FLOAT_EQ(0.0f, webkit_event.force);

+ EXPECT_TRUE(isnan(webkit_event.force));

sadrul 2016/01/29 16:30:43 std::isnan

Navid Zolghadr 2016/02/01 15:41:33 Done.

EXPECT_EQ(123, webkit_event.x);

EXPECT_EQ(123, webkit_event.windowX);

EXPECT_EQ(321, webkit_event.y);

@@ -478,7 +478,7 @@ TEST(WebInputEventAuraTest, TestMakeWebMouseWheelEvent) {

webkit_event.pointerType);

EXPECT_EQ(0, webkit_event.tiltX);

EXPECT_EQ(0, webkit_event.tiltY);

- EXPECT_FLOAT_EQ(0.0f, webkit_event.force);

+ EXPECT_TRUE(isnan(webkit_event.force));

EXPECT_EQ(123, webkit_event.x);

EXPECT_EQ(123, webkit_event.windowX);

EXPECT_EQ(321, webkit_event.y);

@@ -503,7 +503,7 @@ TEST(WebInputEventAuraTest, TestMakeWebMouseWheelEvent) {

webkit_event.pointerType);

EXPECT_EQ(0, webkit_event.tiltX);

EXPECT_EQ(0, webkit_event.tiltY);

- EXPECT_FLOAT_EQ(0.0f, webkit_event.force);

+ EXPECT_TRUE(isnan(webkit_event.force));

EXPECT_EQ(123, webkit_event.x);

EXPECT_EQ(123, webkit_event.windowX);

EXPECT_EQ(321, webkit_event.y);