Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: content/browser/renderer_host/web_input_event_aura.cc

Issue 1617863002: Set the correct pressure for pointer events based on force (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove a typo Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/web_input_event_aura.cc
diff --git a/content/browser/renderer_host/web_input_event_aura.cc b/content/browser/renderer_host/web_input_event_aura.cc
index c4ed46155bd57aed1c11ce8896454b1bec437bfb..157b60b63ab770c22dd3a8ea44e2231919d15d78 100644
--- a/content/browser/renderer_host/web_input_event_aura.cc
+++ b/content/browser/renderer_host/web_input_event_aura.cc
@@ -401,10 +401,14 @@ blink::WebMouseEvent MakeWebMouseEventFromAuraEvent(
webkit_event.tiltX = roundf(event.pointer_details().tilt_x());
webkit_event.tiltY = roundf(event.pointer_details().tilt_y());
- webkit_event.force = event.pointer_details().force();
webkit_event.pointerType =
EventPointerTypeToWebPointerType(event.pointer_details().pointer_type());
+ // TODO(crbug.com/581066): Set mouse pressure if it is supported
+ if (webkit_event.pointerType !=
+ blink::WebPointerProperties::PointerType::Mouse)
+ webkit_event.force = event.pointer_details().force();
sadrul 2016/01/27 18:31:44 Can we update the default value for |ui::PointerDe
Navid Zolghadr 2016/01/27 19:55:48 That would practically add a lot more implications
sadrul 2016/01/27 20:22:05 Can you clarify why you think that would make this
Navid Zolghadr 2016/01/28 18:38:38 Done.
+
return webkit_event;
}
@@ -430,10 +434,14 @@ blink::WebMouseWheelEvent MakeWebMouseWheelEventFromAuraEvent(
webkit_event.tiltX = roundf(event.pointer_details().tilt_x());
webkit_event.tiltY = roundf(event.pointer_details().tilt_y());
- webkit_event.force = event.pointer_details().force();
webkit_event.pointerType =
EventPointerTypeToWebPointerType(event.pointer_details().pointer_type());
+ // TODO(crbug.com/581066): Set mouse pressure if it is supported
+ if (webkit_event.pointerType !=
+ blink::WebPointerProperties::PointerType::Mouse)
+ webkit_event.force = event.pointer_details().force();
sadrul 2016/01/27 18:31:44 ditto
+
return webkit_event;
}
« no previous file with comments | « components/test_runner/event_sender.cc ('k') | content/browser/renderer_host/web_input_event_aura_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698