Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: tools/gn/value.cc

Issue 161783002: Remove default value checking in GN, adds getenv function, reorders parameters to rebase_path. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/functions.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/value.cc
diff --git a/tools/gn/value.cc b/tools/gn/value.cc
index b36c962516fbddb1babfd6e058b1498b3231a1d0..659ebb9bb0b12517864a65e8203bd5a678212ecb 100644
--- a/tools/gn/value.cc
+++ b/tools/gn/value.cc
@@ -8,12 +8,14 @@
Value::Value()
: type_(NONE),
+ boolean_value_(false),
int_value_(0),
origin_(NULL) {
}
Value::Value(const ParseNode* origin, Type t)
: type_(t),
+ boolean_value_(false),
int_value_(0),
origin_(origin) {
}
@@ -35,6 +37,7 @@ Value::Value(const ParseNode* origin, int64 int_val)
Value::Value(const ParseNode* origin, std::string str_val)
: type_(STRING),
string_value_(),
+ boolean_value_(false),
int_value_(0),
origin_(origin) {
string_value_.swap(str_val);
@@ -43,6 +46,7 @@ Value::Value(const ParseNode* origin, std::string str_val)
Value::Value(const ParseNode* origin, const char* str_val)
: type_(STRING),
string_value_(str_val),
+ boolean_value_(false),
int_value_(0),
origin_(origin) {
}
« no previous file with comments | « tools/gn/functions.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698