Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Side by Side Diff: fuzz/FuzzScaleToSides.cpp

Issue 1617763003: Fix bounds of checking if a radii are too long for a side. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Address comment. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/core/SkScaleToSides.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 Google Inc. 2 * Copyright 2016 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 // Reminder of how to run: 8 // Reminder of how to run:
9 // $ env CC=afl-clang CXX=afl-clang++ ./gyp_skia 9 // $ env CC=afl-clang CXX=afl-clang++ ./gyp_skia
10 // $ ninja -C out/Debug fuzz 10 // $ ninja -C out/Debug fuzz
11 // $ afl-fuzz -i fuzz-in -o fuzz-out out/Debug/fuzz -n ScaleToSides -b @@ 11 // $ afl-fuzz -i fuzz-in -o fuzz-out out/Debug/fuzz -n ScaleToSides -b @@
12 // where you seed fuzz-in/ with one or more small files. 12 // where you seed fuzz-in/ with one or more small files.
13 13
14 #include "Fuzz.h" 14 #include "Fuzz.h"
15 #include "SkScaleToSides.h" 15 #include "SkScaleToSides.h"
16 #include <cmath> 16 #include <cmath>
17 17
18 DEF_FUZZ(ScaleToSides, fuzz) { 18 DEF_FUZZ(ScaleToSides, fuzz) {
19 float radius1 = fuzz->nextF(), 19 float radius1 = fuzz->nextF(),
20 radius2 = fuzz->nextF(), 20 radius2 = fuzz->nextF(),
21 width = fuzz->nextF(); 21 width = fuzz->nextF();
22 SkDebugf("%g %g %g\n", radius1, radius2, width);
23 22
24 if (!std::isfinite(radius1) || 23 if (!std::isfinite(radius1) ||
25 !std::isfinite(radius2) || 24 !std::isfinite(radius2) ||
26 !std::isfinite(width)) 25 !std::isfinite(width) ||
26 radius1 <= 0.0f ||
27 radius2 <= 0.0f ||
28 width <= 0.0f)
27 { 29 {
28 fuzz->signalBoring(); 30 fuzz->signalBoring();
29 } 31 }
30 32
31 if (width <= 0.0f) { 33 double scale = (double)width / ((double)radius1 + (double)radius2);
34 if (scale >= 1.0 || scale <= 0.0) {
32 fuzz->signalBoring(); 35 fuzz->signalBoring();
33 } 36 }
34 37 SkDebugf("%g %g %g %g\n", radius1, radius2, width, scale);
35 double scale = (double)width / ((double)radius1 + (double)radius2);
36 if (scale >= 1.0) {
37 fuzz->signalBoring();
38 }
39 ScaleToSides::AdjustRadii(width, scale, &radius1, &radius2); 38 ScaleToSides::AdjustRadii(width, scale, &radius1, &radius2);
40 39
41 // TODO(mtklein): add fuzz->keepResult() 40 // TODO(mtklein): add fuzz->keepResult()
42 volatile float junk = 0.0f; 41 volatile float junk = 0.0f;
43 junk *= radius1; 42 junk *= radius1;
44 junk *= radius2; 43 junk *= radius2;
45 } 44 }
OLDNEW
« no previous file with comments | « no previous file | src/core/SkScaleToSides.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698