Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1817)

Unified Diff: src/parsing/parser.cc

Issue 1617733002: Remove unnecessary RewriteNonPatternArguments (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove ValidateExpression from native calls Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/parser.h ('k') | src/parsing/preparser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parser.cc
diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc
index f5a95acd19907a8a54cf3e12a6aaca1a7543b086..43443a96772aa8d4ce03ae1e50a9bf28b3508365 100644
--- a/src/parsing/parser.cc
+++ b/src/parsing/parser.cc
@@ -4895,7 +4895,6 @@ Expression* Parser::ParseV8Intrinsic(bool* ok) {
ExpressionClassifier classifier;
ZoneList<Expression*>* args =
ParseArguments(&spread_pos, &classifier, CHECK_OK);
- args = RewriteNonPatternArguments(args, &classifier, CHECK_OK);
DCHECK(!spread_pos.IsValid());
@@ -5464,13 +5463,6 @@ Expression* ParserTraits::RewriteNonPattern(
}
-ZoneList<Expression*>* ParserTraits::RewriteNonPatternArguments(
- ZoneList<Expression*>* args, const ExpressionClassifier* classifier,
- bool* ok) {
- return parser_->RewriteNonPatternArguments(args, classifier, ok);
-}
-
-
ObjectLiteralProperty* ParserTraits::RewriteNonPatternObjectLiteralProperty(
ObjectLiteralProperty* property, const ExpressionClassifier* classifier,
bool* ok) {
@@ -5522,22 +5514,6 @@ Expression* Parser::RewriteNonPattern(Expression* expr,
}
-ZoneList<Expression*>* Parser::RewriteNonPatternArguments(
- ZoneList<Expression*>* args, const ExpressionClassifier* classifier,
- bool* ok) {
- ValidateExpression(classifier, ok);
- if (!*ok) return args;
- for (int i = 0; i < args->length(); i++) {
- NonPatternRewriter rewriter(stack_limit_, this);
- Expression* result =
- reinterpret_cast<Expression*>(rewriter.Rewrite(args->at(i)));
- DCHECK_NOT_NULL(result);
- args->Set(i, result);
- }
- return args;
-}
-
-
ObjectLiteralProperty* Parser::RewriteNonPatternObjectLiteralProperty(
ObjectLiteralProperty* property, const ExpressionClassifier* classifier,
bool* ok) {
« no previous file with comments | « src/parsing/parser.h ('k') | src/parsing/preparser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698