Remove unnecessary RewriteNonPatternArguments

src/parsing/parser.cc

Index: src/parsing/parser.cc
diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc
index f5a95acd19907a8a54cf3e12a6aaca1a7543b086..df19c38d98eeb96a4e013517402b6416f12794a3 100644
--- a/src/parsing/parser.cc
+++ b/src/parsing/parser.cc
@@ -4895,7 +4895,7 @@ Expression* Parser::ParseV8Intrinsic(bool* ok) {
   ExpressionClassifier classifier;
   ZoneList<Expression*>* args =
       ParseArguments(&spread_pos, &classifier, CHECK_OK);
-  args = RewriteNonPatternArguments(args, &classifier, CHECK_OK);
+  ValidateExpression(&classifier, CHECK_OK);

[rossberg, 2016/01/21 14:16:37]

Hm, isn't this redundant as well? If the thing has already been rewritten then
it should also have been validated already. What case would this check capture?

[nickie, 2016/01/21 14:29:25]

Honestly, I don't know.  This line was replaced with the call to
RewriteNonPatternArguments here:

https://codereview.chromium.org/1567603005/diff/120001/src/parsing/parser.cc#...

The ParseArguments function makes sure that each argument (if any exist) is
rewritten as a non-pattern.  This practically invokes ValidateExpression for
each argument, in order.  I'm not sure, however, if this is all you need here.

[rossberg, 2016/01/21 14:46:00]

Let's remove it then it see. Having a dangling Validate without Rewrite seems
fishy. If it's actually necessary, I'd think we have a bug elsewhere.

[nickie, 2016/01/21 15:02:53]

Acknowledged.

 
   DCHECK(!spread_pos.IsValid());
 
@@ -5464,13 +5464,6 @@ Expression* ParserTraits::RewriteNonPattern(
 }
 
 
-ZoneList<Expression*>* ParserTraits::RewriteNonPatternArguments(
-    ZoneList<Expression*>* args, const ExpressionClassifier* classifier,
-    bool* ok) {
-  return parser_->RewriteNonPatternArguments(args, classifier, ok);
-}
-
-
 ObjectLiteralProperty* ParserTraits::RewriteNonPatternObjectLiteralProperty(
     ObjectLiteralProperty* property, const ExpressionClassifier* classifier,
     bool* ok) {
@@ -5522,22 +5515,6 @@ Expression* Parser::RewriteNonPattern(Expression* expr,
 }
 
 
-ZoneList<Expression*>* Parser::RewriteNonPatternArguments(
-    ZoneList<Expression*>* args, const ExpressionClassifier* classifier,
-    bool* ok) {
-  ValidateExpression(classifier, ok);
-  if (!*ok) return args;
-  for (int i = 0; i < args->length(); i++) {
-    NonPatternRewriter rewriter(stack_limit_, this);
-    Expression* result =
-        reinterpret_cast<Expression*>(rewriter.Rewrite(args->at(i)));
-    DCHECK_NOT_NULL(result);
-    args->Set(i, result);
-  }
-  return args;
-}
-
-
 ObjectLiteralProperty* Parser::RewriteNonPatternObjectLiteralProperty(
     ObjectLiteralProperty* property, const ExpressionClassifier* classifier,
     bool* ok) {