Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 161773002: Keep package access members in TOC files (Closed)

Created:
6 years, 10 months ago by cjhopman
Modified:
6 years, 10 months ago
Reviewers:
shashi
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Keep package access members in TOC files In some cases we have multiple libraries with the same package name (particularly test+non-test). If one of these depends on the other and refers to package-private stuff in the second, then it should be rebuilt if the signature of package-private stuff is changed. To ensure that happens, the TOC file must include the signatures of package-private members. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
build/android/gyp/jar_toc.py View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cjhopman
shashishekhar: *
6 years, 10 months ago (2014-02-12 22:42:44 UTC) #1
shashi
optional nit: can just use plain javap, without -package, since that is the default behavior. ...
6 years, 10 months ago (2014-02-13 01:44:48 UTC) #2
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 10 months ago (2014-02-13 02:25:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/161773002/1
6 years, 10 months ago (2014-02-13 02:25:39 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 05:08:40 UTC) #5
Message was sent while issue was closed.
Change committed as 250956

Powered by Google App Engine
This is Rietveld 408576698