Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 1617713003: fuzz: list API fuzzing options if -t api and -n matches nothing. (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
kjlubick, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fuzz: list API fuzzing options if -t api and -n matches nothing. Today we segfault if --name is empty. This fixes that too. This updates some terms: -t api lets us fuzz an API. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1617713003 Committed: https://skia.googlesource.com/skia/+/d4387ea99369ee1b89bbc9ffc0d8c203a8923515

Patch Set 1 #

Total comments: 2

Patch Set 2 : guard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M fuzz/fuzz.cpp View 1 2 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
mtklein_C
4 years, 11 months ago (2016-01-21 13:52:46 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1617713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1617713003/1
4 years, 11 months ago (2016-01-21 13:53:01 UTC) #6
kjlubick
https://codereview.chromium.org/1617713003/diff/1/fuzz/fuzz.cpp File fuzz/fuzz.cpp (right): https://codereview.chromium.org/1617713003/diff/1/fuzz/fuzz.cpp#newcode50 fuzz/fuzz.cpp:50: switch (FLAGS_type[0][0]) { This segfaults if --type is empty. ...
4 years, 11 months ago (2016-01-21 13:57:31 UTC) #7
mtklein
On 2016/01/21 13:57:31, kjlubick wrote: > https://codereview.chromium.org/1617713003/diff/1/fuzz/fuzz.cpp > File fuzz/fuzz.cpp (right): > > https://codereview.chromium.org/1617713003/diff/1/fuzz/fuzz.cpp#newcode50 > ...
4 years, 11 months ago (2016-01-21 13:59:35 UTC) #8
mtklein
https://codereview.chromium.org/1617713003/diff/1/fuzz/fuzz.cpp File fuzz/fuzz.cpp (right): https://codereview.chromium.org/1617713003/diff/1/fuzz/fuzz.cpp#newcode50 fuzz/fuzz.cpp:50: switch (FLAGS_type[0][0]) { On 2016/01/21 13:57:31, kjlubick wrote: > ...
4 years, 11 months ago (2016-01-21 14:00:53 UTC) #10
kjlubick
On 2016/01/21 at 14:00:53, mtklein wrote: > https://codereview.chromium.org/1617713003/diff/1/fuzz/fuzz.cpp > File fuzz/fuzz.cpp (right): > > https://codereview.chromium.org/1617713003/diff/1/fuzz/fuzz.cpp#newcode50 ...
4 years, 11 months ago (2016-01-21 14:02:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1617713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1617713003/20001
4 years, 11 months ago (2016-01-21 14:03:17 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 14:13:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d4387ea99369ee1b89bbc9ffc0d8c203a8923515

Powered by Google App Engine
This is Rietveld 408576698