command_buffer_gles2: Avoid creating multiple AtExitManagers

command_buffer_gles2: Avoid creating multiple AtExitManagers

Avoid creating multiple AtExitManagers when libcommand_buffer_gles2
creates multiple EGL displays.

BUG=skia:2992
Committed: https://crrev.com/37c37504085029aa3c933eacbda934551230cfb9
Cr-Commit-Position: refs/heads/master@{#371205}

[Kimmo Kinnunen, 2016-01-21 12:41:17]

kkinnunen@nvidia.com changed reviewers:
+ piman@chromium.org

[piman, 2016-01-21 20:30:47]

https://chromiumcodereview.appspot.com/1617653003/diff/1/gpu/gles2_conform_su...
File gpu/gles2_conform_support/egl/display.cc (right):

https://chromiumcodereview.appspot.com/1617653003/diff/1/gpu/gles2_conform_su...
gpu/gles2_conform_support/egl/display.cc:33: // elg::Display is used for
comformance tests and command_buffer_gles.  We only
nit: typo elg->egl

https://chromiumcodereview.appspot.com/1617653003/diff/1/gpu/gles2_conform_su...
gpu/gles2_conform_support/egl/display.cc:37: base::Lock g_exit_manager_lock;
We don't allow non-POD globals per style (causes global initializers).

A suggestion is to use LazyInstance<base::Lock>::Leaky
(the Leaky version doesn't need the AtExitManager, so it breaks the circular
dependency).

[Kimmo Kinnunen, 2016-01-22 06:53:30]

https://chromiumcodereview.appspot.com/1617653003/diff/1/gpu/gles2_conform_su...
File gpu/gles2_conform_support/egl/display.cc (right):

https://chromiumcodereview.appspot.com/1617653003/diff/1/gpu/gles2_conform_su...
gpu/gles2_conform_support/egl/display.cc:33: // elg::Display is used for
comformance tests and command_buffer_gles.  We only
On 2016/01/21 20:30:47, piman (Slow to review) wrote:
> nit: typo elg->egl

Done.

https://chromiumcodereview.appspot.com/1617653003/diff/1/gpu/gles2_conform_su...
gpu/gles2_conform_support/egl/display.cc:37: base::Lock g_exit_manager_lock;
On 2016/01/21 20:30:47, piman (Slow to review) wrote:
> We don't allow non-POD globals per style (causes global initializers).
> 
> A suggestion is to use LazyInstance<base::Lock>::Leaky
> (the Leaky version doesn't need the AtExitManager, so it breaks the circular
> dependency).

Done.

[piman, 2016-01-22 19:36:50]

lgtm

[Kimmo Kinnunen, 2016-01-25 08:19:14]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2016-01-25 08:19:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1617653003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1617653003/40001

[commit-bot: I haz the power, 2016-01-25 08:48:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-25 08:49:45]

Description was changed from

==========
command_buffer_gles2: Avoid creating multiple AtExitManagers

Avoid creating multiple AtExitManagers when libcommand_buffer_gles2
creates multiple EGL displays.

BUG=skia:2992
==========

to

==========
command_buffer_gles2: Avoid creating multiple AtExitManagers

Avoid creating multiple AtExitManagers when libcommand_buffer_gles2
creates multiple EGL displays.

BUG=skia:2992

Committed: https://crrev.com/37c37504085029aa3c933eacbda934551230cfb9
Cr-Commit-Position: refs/heads/master@{#371205}
==========

[commit-bot: I haz the power, 2016-01-25 08:49:45]

Patchset 3 (id:??) landed as
https://crrev.com/37c37504085029aa3c933eacbda934551230cfb9
Cr-Commit-Position: refs/heads/master@{#371205}