Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 161753003: Use more direct Element creation methods (Closed)

Created:
6 years, 10 months ago by rwlbuis
Modified:
6 years, 10 months ago
Reviewers:
Inactive
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use more direct Element creation methods In both these cases we know the kind of Element we want to create so be more specific and avoid some unneeded instructions. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167104

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
rwlbuis
Eliminate some code paths we do not need to go through.
6 years, 10 months ago (2014-02-13 16:17:36 UTC) #1
Inactive
https://codereview.chromium.org/161753003/diff/1/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/161753003/diff/1/Source/core/dom/Document.cpp#newcode1340 Source/core/dom/Document.cpp:1340: m_titleElement = HTMLTitleElement::create(*this); This no longer updates m_sawElementsInKnownNamespaces. Why ...
6 years, 10 months ago (2014-02-13 17:26:22 UTC) #2
rwlbuis
On 2014/02/13 17:26:22, Chris Dumez wrote: > https://codereview.chromium.org/161753003/diff/1/Source/core/dom/Document.cpp > File Source/core/dom/Document.cpp (right): > > https://codereview.chromium.org/161753003/diff/1/Source/core/dom/Document.cpp#newcode1340 ...
6 years, 10 months ago (2014-02-13 17:41:40 UTC) #3
Inactive
lgtm
6 years, 10 months ago (2014-02-13 17:47:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/161753003/1
6 years, 10 months ago (2014-02-13 17:47:45 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 19:03:21 UTC) #6
Message was sent while issue was closed.
Change committed as 167104

Powered by Google App Engine
This is Rietveld 408576698