src/arm/simulator-arm.cc - Issue 1617503003: [Atomics] code stubs for atomic operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/simulator-arm.cc

Issue 1617503003: [Atomics] code stubs for atomic operations (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: remove unnecessary CSA additions Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/simulator-arm.cc

diff --git a/src/arm/simulator-arm.cc b/src/arm/simulator-arm.cc

index 563912bf6fa14e5c0d1dfb06fa033c097f288023..ad405255f882291faf91ebf71dd621be32dce393 100644

--- a/src/arm/simulator-arm.cc

+++ b/src/arm/simulator-arm.cc

@@ -3904,6 +3904,9 @@ void Simulator::DecodeSpecialCondition(Instruction* instr) {

case 0xB:

if ((instr->Bits(22, 20) == 5) && (instr->Bits(15, 12) == 0xf)) {

// pld: ignore instruction.

+ } else if (instr->SpecialValue() == 0xA && instr->Bits(22, 20) == 7) {

+ // dsb, dmb, isb: ignore instruction for now.

+ // TODO(binji): implement

} else {

UNIMPLEMENTED();

}