Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1617493002: [DevTools] Initialize DeviceModeView lazily. (Closed)

Created:
4 years, 11 months ago by dgozman
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Initialize DeviceModeView lazily. This saves a little time on startup. BUG=540864 Committed: https://crrev.com/1d248c223d2972bf4efcee00ba2ea92c14829977 Cr-Commit-Position: refs/heads/master@{#371597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dgozman
Take a look please.
4 years, 11 months ago (2016-01-26 01:51:43 UTC) #3
pfeldman
lgtm
4 years, 11 months ago (2016-01-26 18:23:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1617493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1617493002/1
4 years, 11 months ago (2016-01-26 18:34:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 21:09:25 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 21:10:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d248c223d2972bf4efcee00ba2ea92c14829977
Cr-Commit-Position: refs/heads/master@{#371597}

Powered by Google App Engine
This is Rietveld 408576698