Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Issue 161743002: Revert 250798 "Revert of Read compositor VSync information from ..." (Closed)

Created:
6 years, 10 months ago by Sergey Ulanov
Modified:
6 years, 10 months ago
Reviewers:
sheu
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 250798 "Revert of Read compositor VSync information from ..." Broke compilation. > Revert of Read compositor VSync information from platform, when possible (https://chromiumcodereview.appspot.com/138903025/) > > Reason for revert: > Reverting due to Windows crashes. See: > > http://crbug.com/343199 > > Original issue's description: > > Read compositor VSync information from platform, when possible > > > > The current query of VSync information through the GL context can be unreliable > > on platforms that can dynamically disable vblanks, or multi-monitor setups. > > Preferentially query the VSync information through the platform windowing > > system (presently: XRandR on CrOS) when possible. > > > > BUG=328953 > > TEST=local build, run on CrOS snow > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250250 > > TBR=oshima@chromium.org,piman@chromium.org,brianderson@chromium.org,sky@chromium.org,mukai@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=328953 > > Review URL: https://codereview.chromium.org/161413002 TBR=sheu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -386 lines) Patch
trunk/src/ash/display/display_change_observer_chromeos.h View 2 chunks +2 lines, -2 lines 0 comments Download
trunk/src/ash/display/display_change_observer_chromeos.cc View 4 chunks +36 lines, -33 lines 0 comments Download
trunk/src/ash/display/display_change_observer_chromeos_unittest.cc View 2 chunks +24 lines, -18 lines 0 comments Download
trunk/src/ash/display/display_controller.cc View 2 chunks +9 lines, -0 lines 0 comments Download
trunk/src/ash/display/display_info.h View 5 chunks +24 lines, -19 lines 0 comments Download
trunk/src/ash/display/display_info.cc View 5 chunks +51 lines, -20 lines 0 comments Download
trunk/src/ash/display/display_info_unittest.cc View 1 chunk +10 lines, -5 lines 0 comments Download
trunk/src/ash/display/display_manager.h View 2 chunks +5 lines, -5 lines 0 comments Download
trunk/src/ash/display/display_manager.cc View 5 chunks +31 lines, -37 lines 0 comments Download
trunk/src/ash/display/display_manager_unittest.cc View 2 chunks +49 lines, -33 lines 0 comments Download
trunk/src/ash/display/resolution_notification_controller_unittest.cc View 12 chunks +67 lines, -54 lines 0 comments Download
trunk/src/ash/wm/window_animations.cc View 1 chunk +0 lines, -4 lines 0 comments Download
trunk/src/cc/output/output_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
trunk/src/cc/output/output_surface.cc View 1 chunk +8 lines, -5 lines 0 comments Download
trunk/src/cc/output/output_surface_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
trunk/src/chrome/browser/chromeos/display/display_preferences.cc View 1 chunk +5 lines, -4 lines 0 comments Download
trunk/src/chrome/browser/chromeos/display/display_preferences_unittest.cc View 6 chunks +10 lines, -16 lines 0 comments Download
trunk/src/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 6 chunks +23 lines, -17 lines 0 comments Download
trunk/src/content/browser/compositor/browser_compositor_output_surface.h View 4 chunks +11 lines, -13 lines 0 comments Download
trunk/src/content/browser/compositor/browser_compositor_output_surface.cc View 6 chunks +15 lines, -15 lines 0 comments Download
trunk/src/content/browser/compositor/browser_compositor_output_surface_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
trunk/src/content/browser/compositor/gpu_browser_compositor_output_surface.h View 2 chunks +5 lines, -2 lines 0 comments Download
trunk/src/content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 chunk +2 lines, -4 lines 0 comments Download
trunk/src/content/browser/compositor/gpu_process_transport_factory.cc View 2 chunks +2 lines, -4 lines 0 comments Download
trunk/src/content/browser/compositor/software_browser_compositor_output_surface.h View 2 chunks +5 lines, -7 lines 0 comments Download
trunk/src/content/browser/compositor/software_browser_compositor_output_surface.cc View 1 chunk +2 lines, -4 lines 0 comments Download
trunk/src/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
trunk/src/content/browser/renderer_host/media/desktop_capture_device_aura.cc View 1 chunk +0 lines, -3 lines 0 comments Download
trunk/src/content/browser/renderer_host/render_widget_host_view_aura.h View 3 chunks +5 lines, -2 lines 0 comments Download
trunk/src/content/browser/renderer_host/render_widget_host_view_aura.cc View 3 chunks +10 lines, -3 lines 0 comments Download
trunk/src/content/renderer/gpu/compositor_output_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
trunk/src/content/renderer/gpu/compositor_output_surface.cc View 2 chunks +6 lines, -4 lines 0 comments Download
trunk/src/ui/aura/bench/bench_main.cc View 1 chunk +0 lines, -5 lines 0 comments Download
trunk/src/ui/compositor/compositor.h View 5 chunks +8 lines, -5 lines 0 comments Download
trunk/src/ui/compositor/compositor.cc View 4 chunks +6 lines, -7 lines 0 comments Download
trunk/src/ui/compositor/compositor.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
trunk/src/ui/compositor/compositor_observer.h View 1 chunk +0 lines, -5 lines 0 comments Download
trunk/src/ui/compositor/compositor_vsync_manager.h View 0 chunks +-1 lines, --1 lines 0 comments Download
trunk/src/ui/compositor/compositor_vsync_manager.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
trunk/src/ui/compositor/layer_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
trunk/src/ui/compositor/test/draw_waiter_for_test.h View 1 chunk +0 lines, -3 lines 0 comments Download
trunk/src/ui/compositor/test/draw_waiter_for_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
trunk/src/ui/gl/sync_control_vsync_provider.cc View 1 chunk +17 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sergey Ulanov
6 years, 10 months ago (2014-02-12 22:35:41 UTC) #1
Sergey Ulanov
6 years, 10 months ago (2014-02-12 22:35:43 UTC) #2
Sergey Ulanov
6 years, 10 months ago (2014-02-12 22:35:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #0 manually as r250810 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698