- Create isolate specific resuable handles and use them in the hot lookup paths.

runtime/vm/isolate.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/json.h"
 #include "lib/mirrors.h"
@@ skipping 353 matching lines @@
       OS::PrintErr("    %s <- %s\n",
                    String::Handle(field.name()).ToCString(),
                    value.ToCString());
     }
   }
 
   object_ = &obj;
 }
 
 
+#define REUSABLE_HANDLE_INITIALIZERS(object)                                   \
+  object##_handle_(NULL),
+
 Isolate::Isolate()
     : store_buffer_(),
       message_notify_callback_(NULL),
       name_(NULL),
       start_time_(OS::GetCurrentTimeMicros()),
       main_port_(0),
       heap_(NULL),
       object_store_(NULL),
       top_context_(Context::null()),
       top_exit_frame_info_(0),
@@ skipping 18 matching lines @@
       deopt_cpu_registers_copy_(NULL),
       deopt_fpu_registers_copy_(NULL),
       deopt_frame_copy_(NULL),
       deopt_frame_copy_size_(0),
       deferred_boxes_(NULL),
       deferred_object_refs_(NULL),
       deferred_objects_count_(0),
       deferred_objects_(NULL),
       stacktrace_(NULL),
       stack_frame_index_(-1),
-      object_histogram_(NULL) {
+      object_histogram_(NULL),
+      REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_INITIALIZERS)
+      handles_() {
   if (FLAG_print_object_histogram && (Dart::vm_isolate() != NULL)) {
     object_histogram_ = new ObjectHistogram(this);
   }
 }
+#undef REUSABLE_HANDLE_INITIALIZERS
 
 
 Isolate::~Isolate() {
   delete [] name_;
   delete heap_;
   delete object_store_;
   delete api_state_;
   delete stub_code_;
   delete debugger_;
 #if defined(USING_SIMULATOR)
@@ skipping 27 matching lines @@
 
 
 Isolate* Isolate::Init(const char* name_prefix) {
   Isolate* result = new Isolate();
   ASSERT(result != NULL);
 
   // TODO(5411455): For now just set the recently created isolate as
   // the current isolate.
   SetCurrent(result);
 
+  // Setup the isolate specific resuable handles.
+#define REUSABLE_HANDLE_ALLOCATION(object)                                     \
+  result->object##_handle_ = result->AllocateReusableHandle<object>();         \
+
+  REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_ALLOCATION)
+#undef REUSABLE_HANDLE_ALLOCATION
+
   // Setup the isolate message handler.
   MessageHandler* handler = new IsolateMessageHandler(result);
   ASSERT(handler != NULL);
   result->set_message_handler(handler);
 
   // Setup the Dart API state.
   ApiState* state = new ApiState();
   ASSERT(state != NULL);
   result->set_api_state(state);
 
@@ skipping 344 matching lines @@
 
   // Visit objects in the megamorphic cache.
   megamorphic_cache_table()->VisitObjectPointers(visitor);
 
   // Visit objects in per isolate stubs.
   StubCode::VisitObjectPointers(visitor);
 
   // Visit objects in zones.
   current_zone()->VisitObjectPointers(visitor);
 
+  // Visit objects in isolate specific handles area.
+  handles_.VisitObjectPointers(visitor);
+
   // Iterate over all the stack frames and visit objects on the stack.
   StackFrameIterator frames_iterator(validate_frames);
   StackFrame* frame = frames_iterator.NextFrame();
   while (frame != NULL) {
     frame->VisitObjectPointers(visitor);
     frame = frames_iterator.NextFrame();
   }
 
   // Visit the dart api state for all local and persistent handles.
   if (api_state() != NULL) {
@@ skipping 205 matching lines @@
       return isolate->GetStatusStackFrame(frame_index);
     }
   }
 
   // TODO(tball): "/isolate/<handle>/stacktrace/<frame-index>"/disassemble"
 
   return NULL;  // Unimplemented query.
 }
 
 
+template<class T>
+T* Isolate::AllocateReusableHandle() {
+  T* handle = reinterpret_cast<T*>(handles_.AllocateScopedHandle());
+  T::initializeHandle(handle, T::null());
+  return handle;
+}
+
+
 static void FillDeferredSlots(DeferredSlot** slot_list) {
   DeferredSlot* slot = *slot_list;
   *slot_list = NULL;
 
   while (slot != NULL) {
     DeferredSlot* current = slot;
     slot = slot->next();
 
     current->Materialize();
 
@@ skipping 95 matching lines @@
   return func.raw();
 }
 
 
 void IsolateSpawnState::Cleanup() {
   SwitchIsolateScope switch_scope(isolate());
   Dart::ShutdownIsolate();
 }
 
 }  // namespace dart