chrome/renderer/resources/extensions/miscellaneous_bindings.js - Issue 16174005: Implement externally_connectable! Web pages can now communicate directly with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/miscellaneous_bindings.js

Issue 16174005: Implement externally_connectable! Web pages can now communicate directly with (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: absolute path... Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/runtime_custom_bindings.cc ('k') | chrome/renderer/resources/extensions/runtime_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/miscellaneous_bindings.js

diff --git a/chrome/renderer/resources/extensions/miscellaneous_bindings.js b/chrome/renderer/resources/extensions/miscellaneous_bindings.js

index 108835c7369ce5a61e020a2c68699f4d4f86da19..3fc701066c69f4235ebf97d3bd54e9bde66eaa20 100644

--- a/chrome/renderer/resources/extensions/miscellaneous_bindings.js

+++ b/chrome/renderer/resources/extensions/miscellaneous_bindings.js

@@ -205,7 +205,9 @@

// the right event.

var isExternal = sourceExtensionId != extensionId;

- var sender = {id: sourceExtensionId};

+ var sender = {};

+ if (sourceExtensionId != '')

+ sender.id = sourceExtensionId;

if (sourceUrl)

sender.url = sourceUrl;

if (sourceTab)