Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7506)

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 16174005: Implement externally_connectable! Web pages can now communicate directly with (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: absolute path... Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/dispatcher.cc
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc
index a55632f067440c3ac29ce89955defe6f01159700..39a7c26873787c4300c90401f5fa8928157c1868 100644
--- a/chrome/renderer/extensions/dispatcher.cc
+++ b/chrome/renderer/extensions/dispatcher.cc
@@ -995,9 +995,9 @@ void Dispatcher::DidCreateScriptContext(
switch (context_type) {
case Feature::UNSPECIFIED_CONTEXT:
case Feature::WEB_PAGE_CONTEXT:
- // TODO(kalman): see comment below about ExtensionAPI.
- InstallBindings(module_system, v8_context, "app");
- InstallBindings(module_system, v8_context, "webstore");
+ RegisterBinding("app", context);
+ RegisterBinding("runtime", context); // for connect() and sendMessage()
+ RegisterBinding("webstore", context);
break;
case Feature::BLESSED_EXTENSION_CONTEXT:
case Feature::UNBLESSED_EXTENSION_CONTEXT:

Powered by Google App Engine
This is Rietveld 408576698