Implement externally_connectable! Web pages can now communicate directly with

chrome/common/extensions/manifest_handlers/externally_connectable.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_EXTERNALLY_CONNECTABLE_H_
 #define CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_EXTERNALLY_CONNECTABLE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 42 matching lines @@
 
   // Tries to construct the info based on |value|, as it would have appeared in
   // the manifest. Sets |error| and returns an empty scoped_ptr on failure.
   static scoped_ptr<ExternallyConnectableInfo> FromValue(
       const base::Value& value,
       string16* error);
 
   virtual ~ExternallyConnectableInfo();
 
   // The URL patterns that are allowed to connect/sendMessage.
   const URLPatternSet matches;

[Jeffrey Yasskin, 2013/06/08 02:27:47]

"url_matches"?

[not at google - send to devlin, 2013/06/08 02:36:50]

we use matches elsewhere to mean URLs (notably content scripts, ideally want to
be consistent here.

 
-  // The extension IDs that are allowed to connect/sendMessage.
+  // The extension IDs that are allowed to connect/sendMessage. Sorted.
   const std::vector<std::string> ids;
 
   // True if any extension is allowed to connect. This would have corresponded
   // to an ID of "*" in |ids|.
   const bool matches_all_ids;
 
- private:
+  // Returns true if |ids| contains |id| or if |matches_all_ids| is true.
+  //
+  // More convenient for callers than checking each individually, and it makes
+  // use of the sortedness of |ids|.
+  bool MatchesIdOrAllIds(const std::string& id);

[Jeffrey Yasskin, 2013/06/08 02:27:47]

I might just call this "MatchesId" since if it matches all ids it definitely
matches this one.

[not at google - send to devlin, 2013/06/08 02:36:50]

now you've inspired me to not use the term "matches" anywhere else but with the
URLs. I see your point.

+
+  // Public only for testing. Use FromValue in production.
   ExternallyConnectableInfo(const URLPatternSet& matches,
                             const std::vector<std::string>& ids,
                             bool matches_all_ids);
 
+ private:
   DISALLOW_COPY_AND_ASSIGN(ExternallyConnectableInfo);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_EXTERNALLY_CONNECTABLE_H_