Implement externally_connectable! Web pages can now communicate directly with

chrome/renderer/extensions/runtime_custom_bindings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/runtime_custom_bindings.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 #include "chrome/common/extensions/extension.h"
@@ skipping 29 matching lines @@
 
 v8::Handle<v8::Value> RuntimeCustomBindings::OpenChannelToExtension(
     const v8::Arguments& args) {
   // Get the current RenderView so that we can send a routed IPC message from
   // the correct source.
   content::RenderView* renderview = GetRenderView();
   if (!renderview)
     return v8::Undefined();
 
   // The Javascript code should validate/fill the arguments.
-  CHECK(args.Length() >= 3 &&
-        args[0]->IsString() &&
-        args[1]->IsString() &&
-        args[2]->IsString());
+  CHECK_EQ(2, args.Length());
+  CHECK(args[0]->IsString() && args[1]->IsString());
 
   ExtensionMsg_ExternalConnectionInfo info;

[Jeffrey Yasskin, 2013/06/08 00:28:09]

This is where you'd need to record whether the event was user-initiated, right?
https://code.google.com/p/chromium/issues/detail?id=55316#c66

[not at google - send to devlin, 2013/06/08 02:02:33]

Yeah, but it's something for developers not something we're gating this API call
on. I'll do in a follow up.

-  info.source_id = *v8::String::Utf8Value(args[0]->ToString());
-  info.target_id = *v8::String::Utf8Value(args[1]->ToString());
+  info.source_id = context()->extension() ? context()->extension()->id() : "";
+  info.target_id = *v8::String::Utf8Value(args[0]->ToString());
   info.source_url = renderview->GetWebView()->mainFrame()->document().url();
-  std::string channel_name = *v8::String::Utf8Value(args[2]->ToString());
+  std::string channel_name = *v8::String::Utf8Value(args[1]->ToString());
   int port_id = -1;
   renderview->Send(new ExtensionHostMsg_OpenChannelToExtension(
       renderview->GetRoutingID(), info, channel_name, &port_id));
   return v8::Integer::New(port_id);
 }
 
 v8::Handle<v8::Value> RuntimeCustomBindings::OpenChannelToNativeApp(
     const v8::Arguments& args) {
   // Verify that the extension has permission to use native messaging.
   if (!dispatcher()->CheckContextAccessToExtensionAPI(
@@ skipping 27 matching lines @@
 v8::Handle<v8::Value> RuntimeCustomBindings::GetManifest(
     const v8::Arguments& args) {
   CHECK(context()->extension());
 
   scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
   return converter->ToV8Value(context()->extension()->manifest()->value(),
                               context()->v8_context());
 }
 
 }  // extensions