Implement externally_connectable! Web pages can now communicate directly with

chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/common/extensions/features/feature.h"
 #include "chrome/common/extensions/manifest_handlers/externally_connectable.h"
 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
@@ skipping 22 matching lines @@
 
   EXPECT_TRUE(extension->HasAPIPermission(APIPermission::kWebConnectable));
 
   ExternallyConnectableInfo* info =
       ExternallyConnectableInfo::Get(extension.get());
   ASSERT_TRUE(info);
 
   EXPECT_THAT(info->ids, ElementsAre("abcdefghijklmnopabcdefghijklmnop",
                                      "ponmlkjihgfedcbaponmlkjihgfedcba"));
 
-  EXPECT_FALSE(info->matches_all_ids);
+  EXPECT_FALSE(info->all_ids);
 
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://example.com")));
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://example.com/")));
   EXPECT_FALSE(info->matches.MatchesURL(GURL("http://example.com/index.html")));
 
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://google.com")));
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://google.com/")));
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://google.com/index.html")));
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://www.google.com")));
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://www.google.com/")));
@@ skipping 39 matching lines @@
 
   EXPECT_FALSE(extension->HasAPIPermission(APIPermission::kWebConnectable));
 
   ExternallyConnectableInfo* info =
       ExternallyConnectableInfo::Get(extension.get());
   ASSERT_TRUE(info);
 
   EXPECT_THAT(info->ids, ElementsAre("abcdefghijklmnopabcdefghijklmnop",
                                      "ponmlkjihgfedcbaponmlkjihgfedcba"));
 
-  EXPECT_FALSE(info->matches_all_ids);
+  EXPECT_FALSE(info->all_ids);
 
   EXPECT_FALSE(info->matches.MatchesURL(GURL("http://google.com/index.html")));
 }
 
 TEST_F(ExternallyConnectableTest, Matches) {
   scoped_refptr<Extension> extension =
       LoadAndExpectSuccess("externally_connectable_matches.json");
   ASSERT_TRUE(extension.get());
 
   EXPECT_TRUE(extension->HasAPIPermission(APIPermission::kWebConnectable));
 
   ExternallyConnectableInfo* info =
       ExternallyConnectableInfo::Get(extension.get());
   ASSERT_TRUE(info);
 
   EXPECT_THAT(info->ids, ElementsAre());
 
-  EXPECT_FALSE(info->matches_all_ids);
+  EXPECT_FALSE(info->all_ids);
 
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://example.com")));
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://example.com/")));
   EXPECT_FALSE(info->matches.MatchesURL(GURL("http://example.com/index.html")));
 
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://google.com")));
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://google.com/")));
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://google.com/index.html")));
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://www.google.com")));
   EXPECT_TRUE(info->matches.MatchesURL(GURL("http://www.google.com/")));
@@ skipping 20 matching lines @@
 
   EXPECT_FALSE(extension->HasAPIPermission(APIPermission::kWebConnectable));
 
   ExternallyConnectableInfo* info =
       ExternallyConnectableInfo::Get(extension.get());
   ASSERT_TRUE(info);
 
   EXPECT_THAT(info->ids, ElementsAre("abcdefghijklmnopabcdefghijklmnop",
                                      "ponmlkjihgfedcbaponmlkjihgfedcba"));
 
-  EXPECT_TRUE(info->matches_all_ids);
+  EXPECT_TRUE(info->all_ids);
 
   EXPECT_FALSE(info->matches.MatchesURL(GURL("http://google.com/index.html")));
 }
 
+TEST_F(ExternallyConnectableTest, IdCanConnect) {
+  // Not in order to test that ExternallyConnectableInfo sorts it.
+  std::string matches_ids_array[] = { "g", "h", "c", "i", "a", "z", "b" };
+  std::vector<std::string> matches_ids(
+      matches_ids_array, matches_ids_array + arraysize(matches_ids_array));
+
+  std::string nomatches_ids_array[] = { "2", "3", "1" };
+
+  // all_ids = false.
+  {
+    ExternallyConnectableInfo info(URLPatternSet(), matches_ids, false);
+    for (size_t i = 0; i < matches_ids.size(); ++i)
+      EXPECT_TRUE(info.IdCanConnect(matches_ids[i]));
+    for (size_t i = 0; i < arraysize(nomatches_ids_array); ++i)
+      EXPECT_FALSE(info.IdCanConnect(nomatches_ids_array[i]));
+  }
+
+  // all_ids = true.
+  {
+    ExternallyConnectableInfo info(URLPatternSet(), matches_ids, true);
+    for (size_t i = 0; i < matches_ids.size(); ++i)
+      EXPECT_TRUE(info.IdCanConnect(matches_ids[i]));
+    for (size_t i = 0; i < arraysize(nomatches_ids_array); ++i)
+      EXPECT_TRUE(info.IdCanConnect(nomatches_ids_array[i]));
+  }
+}
+
 TEST_F(ExternallyConnectableTest, ErrorWrongFormat) {
   RunTestcase(Testcase("externally_connectable_error_wrong_format.json",
                        errors::kErrorInvalid),
               EXPECT_TYPE_ERROR);
 }
 
 TEST_F(ExternallyConnectableTest, ErrorBadID) {
   RunTestcase(Testcase("externally_connectable_bad_id.json",
                        ErrorUtils::FormatErrorMessage(errors::kErrorInvalidId,
                                                       "badid")),
@@ skipping 53 matching lines @@
       Testcase(
           "externally_connectable_error_unknown_tld.json",
           ErrorUtils::FormatErrorMessage(
               errors::kErrorTopLevelDomainsNotAllowed,
               "notatld",
               "http://*.notatld/*")),
       EXPECT_TYPE_ERROR);
 }
 
 }  // namespace extensions