[DevTools] Not use with statement for evaluated console command

[DevTools] Not use with statement for evaluated console command

Inject command line API with API symbol.
With this CL let, const and use_strict work in console correctly.

BUG=542594, 110163
R=pfeldman@chromium.org

Committed: https://crrev.com/38b555367eaa0f03931b75ea9134148659e45bd7
Cr-Commit-Position: refs/heads/master@{#371110}

[kozy, 2016-01-22 02:29:40]

ptal

[pfeldman, 2016-01-22 18:26:31]

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
(right):

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp:67: 
revert

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp:330:
v8::Isolate* isolate = info.GetIsolate();
This code is hot, you should make sure you only enter it when inspector is
engaged and/or for a whitelist of the values for name.

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InjectedScriptSource.js (right):

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InjectedScriptSource.js:861: prefix =
"with (typeof __scopeChainForEval !== 'undefined' ? __scopeChainForEval[" + i +
"] : { __proto__: null }) {" + (suffix ? " " : "") + prefix;
Can we fix this as well?

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp
(right):

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp:356:
v8::Local<v8::Symbol> commandLineAPISymbol = v8::Symbol::ForApi(isolate,
v8AtomicString(isolate, "commandLineAPISymbol"));
This should be a shared constant or you should declare getter here and access it
via inspector/v8 API.

[kozy, 2016-01-22 19:48:23]

All done!

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
(right):

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp:67: 
On 2016/01/22 18:26:30, pfeldman wrote:
> revert

Done.

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp:330:
v8::Isolate* isolate = info.GetIsolate();
On 2016/01/22 18:26:30, pfeldman wrote:
> This code is hot, you should make sure you only enter it when inspector is
> engaged and/or for a whitelist of the values for name.

Done.

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InjectedScriptSource.js (right):

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InjectedScriptSource.js:861: prefix =
"with (typeof __scopeChainForEval !== 'undefined' ? __scopeChainForEval[" + i +
"] : { __proto__: null }) {" + (suffix ? " " : "") + prefix;
On 2016/01/22 18:26:30, pfeldman wrote:
> Can we fix this as well?

Yes, I'd like to make it in separate CL. Because we've another issue related to
this object while evaluating on async call stack.

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp
(right):

https://codereview.chromium.org/1617393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp:356:
v8::Local<v8::Symbol> commandLineAPISymbol = v8::Symbol::ForApi(isolate,
v8AtomicString(isolate, "commandLineAPISymbol"));
On 2016/01/22 18:26:30, pfeldman wrote:
> This should be a shared constant or you should declare getter here and access
it
> via inspector/v8 API.

Done.

[kozy, 2016-01-22 19:50:45]

Patchset #3 (id:40001) has been deleted

[kozy, 2016-01-22 19:51:23]

Description was changed from

==========
[DevTools] Not use with statement for evaluated console command

Inject command line API with API symbol.
With this CL let, const and use_strict work in console correctly.

BUG=544368
R=pfeldman@chromium.org
==========

to

==========
[DevTools] Not use with statement for evaluated console command

Inject command line API with API symbol.
With this CL let, const and use_strict work in console correctly.

BUG=542594, 110163
R=pfeldman@chromium.org
==========

[pfeldman, 2016-01-23 00:23:00]

lgtm

[kozy, 2016-01-23 00:33:19]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-01-23 00:36:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1617393002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1617393002/80001

[commit-bot: I haz the power, 2016-01-23 00:44:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-23 00:44:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)

[kozy, 2016-01-23 00:46:32]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-01-23 00:48:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1617393002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1617393002/80001

[commit-bot: I haz the power, 2016-01-23 01:16:06]

Description was changed from

==========
[DevTools] Not use with statement for evaluated console command

Inject command line API with API symbol.
With this CL let, const and use_strict work in console correctly.

BUG=542594, 110163
R=pfeldman@chromium.org
==========

to

==========
[DevTools] Not use with statement for evaluated console command

Inject command line API with API symbol.
With this CL let, const and use_strict work in console correctly.

BUG=542594, 110163
R=pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2016-01-23 01:16:06]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-01-23 01:17:33]

Description was changed from

==========
[DevTools] Not use with statement for evaluated console command

Inject command line API with API symbol.
With this CL let, const and use_strict work in console correctly.

BUG=542594, 110163
R=pfeldman@chromium.org
==========

to

==========
[DevTools] Not use with statement for evaluated console command

Inject command line API with API symbol.
With this CL let, const and use_strict work in console correctly.

BUG=542594, 110163
R=pfeldman@chromium.org

Committed: https://crrev.com/38b555367eaa0f03931b75ea9134148659e45bd7
Cr-Commit-Position: refs/heads/master@{#371110}
==========

[commit-bot: I haz the power, 2016-01-23 01:17:34]

Patchset 4 (id:??) landed as
https://crrev.com/38b555367eaa0f03931b75ea9134148659e45bd7
Cr-Commit-Position: refs/heads/master@{#371110}