third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp - Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp

Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix oilpan compilation Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp

diff --git a/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp b/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp

index 87044fadd0095b00fc146a8f7afc5bec72b3a09f..bb2de9aab82707d93322cd38b028f0ebbcb54aae 100644

--- a/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp

+++ b/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp

@@ -67,7 +67,7 @@ const HeapVector<Member<SpeechSynthesisVoice>>& SpeechSynthesis::getVoices()

return m_voiceList;

// If the voiceList is empty, that's the cue to get the voices from the platform again.

- const HeapVector<Member<PlatformSpeechSynthesisVoice>>& platformVoices = m_platformSpeechSynthesizer->voiceList();

+ const Vector<RefPtr<PlatformSpeechSynthesisVoice>>& platformVoices = m_platformSpeechSynthesizer->voiceList();

size_t voiceCount = platformVoices.size();

for (size_t k = 0; k < voiceCount; k++)

m_voiceList.append(SpeechSynthesisVoice::create(platformVoices[k]));

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/speech/SpeechSynthesisVoice.h » ('j') | no next file with comments »