Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4904)

Unified Diff: chrome/browser/resources/supervised_user_block_interstitial.js

Issue 1617293002: Putting the feedback section of the block interstitial to the correct place based on the mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Using i18n-values Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/supervised_user_block_interstitial.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/supervised_user_block_interstitial.js
diff --git a/chrome/browser/resources/supervised_user_block_interstitial.js b/chrome/browser/resources/supervised_user_block_interstitial.js
index e41ab19fc340136709cfc6fa01d8b6a407b1ada2..dc1532c4d06b1ed9e162cb6a928bdb4f725e75ee 100644
--- a/chrome/browser/resources/supervised_user_block_interstitial.js
+++ b/chrome/browser/resources/supervised_user_block_interstitial.js
@@ -67,11 +67,12 @@ function initialize() {
$('request-access-button').classList.remove('hidden-on-mobile');
};
if (loadTimeData.getBoolean('showFeedbackLink')) {
+ $('feedback').hidden = false;
$('feedback-link').onclick = function(event) {
sendCommand('feedback');
};
} else {
- $('feedback-link').style.display = 'none';
+ $('feedback').hidden = true;
Bernhard Bauer 2016/01/28 14:00:42 Actually, do we need this if the link starts out a
atanasova 2016/01/28 14:32:57 I went with the second suggestion, trying to keep
}
}
« no previous file with comments | « chrome/browser/resources/supervised_user_block_interstitial.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698