Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4053)

Unified Diff: chrome/browser/resources/supervised_user_block_interstitial.js

Issue 1617293002: Putting the feedback section of the block interstitial to the correct place based on the mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/supervised_user_block_interstitial.js
diff --git a/chrome/browser/resources/supervised_user_block_interstitial.js b/chrome/browser/resources/supervised_user_block_interstitial.js
index e41ab19fc340136709cfc6fa01d8b6a407b1ada2..6c9e7eb6b3a0e2692873e5b36b617744cb7ae5a3 100644
--- a/chrome/browser/resources/supervised_user_block_interstitial.js
+++ b/chrome/browser/resources/supervised_user_block_interstitial.js
@@ -67,11 +67,12 @@ function initialize() {
$('request-access-button').classList.remove('hidden-on-mobile');
};
if (loadTimeData.getBoolean('showFeedbackLink')) {
+ $('feedback').innerHTML = loadTimeData.getString('feedbackLink');
$('feedback-link').onclick = function(event) {
sendCommand('feedback');
};
} else {
- $('feedback-link').style.display = 'none';
+ $('feedback').hidden = true;
Marc Treib 2016/01/22 00:35:52 I guess this is now technically not required anymo
atanasova 2016/01/22 19:32:24 Done.
}
}

Powered by Google App Engine
This is Rietveld 408576698