Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: content/renderer/media/peer_connection_tracker.cc

Issue 1617243005: Apply new-style constraints to video_source. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add <vector> include Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/peer_connection_tracker.cc
diff --git a/content/renderer/media/peer_connection_tracker.cc b/content/renderer/media/peer_connection_tracker.cc
index 63d6f56ae024a38ba037a66168ba4514d0cdda9e..a2963482507d8c1b780a585ab0e4bcacc45af4ca 100644
--- a/content/renderer/media/peer_connection_tracker.cc
+++ b/content/renderer/media/peer_connection_tracker.cc
@@ -50,6 +50,9 @@ static RTCMediaConstraints GetNativeMediaConstraints(
if (constraints.isNull())
return native_constraints;
+#if 0
mcasas 2016/01/26 16:08:02 Please remove this before committing.
hta - Chromium 2016/01/26 19:35:25 Change undone - will be done properly in later CL.
+ // TODO(hta): Return something stringifiable for new-style constraints.
+ // For now, return as if constraints were empty.
mcasas 2016/01/26 16:08:02 TODO()s must have a http://crbug.com/... bug assoc
hta - Chromium 2016/01/26 19:35:25 Acknowledged.
blink::WebVector<blink::WebMediaConstraint> mandatory;
constraints.getMandatoryConstraints(mandatory);
for (size_t i = 0; i < mandatory.size(); ++i) {
@@ -63,6 +66,7 @@ static RTCMediaConstraints GetNativeMediaConstraints(
native_constraints.AddOptional(
optional[i].m_name.utf8(), optional[i].m_value.utf8(), false);
}
+#endif
return native_constraints;
}

Powered by Google App Engine
This is Rietveld 408576698