Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 1617213003: Fix GN configuration for inclusion of unwinding tables. (Closed)

Created:
4 years, 11 months ago by Yaron
Modified:
4 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, michaelbai_brett: can you take a look? andrew is ooo this week and next and this is needed for official buildschromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN configuration for inclusion of unwinding tables. build/config/compiler/BUILD.gn was already selecting between -fno-unwind-tables and -funwind-tables depending on whether it's an official build or not. Duplicating this flag causes both -fno-unwind-tables and -funwind-tables which results in unwind tables being included and a much larger shared library. BUG=580374 Committed: https://crrev.com/33ecd69e345149844bef8f1026aebcb5f38afcec Cr-Commit-Position: refs/heads/master@{#371044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/config/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Yaron
Brett: can you take a look? Andrew is OOO this week and next and this ...
4 years, 11 months ago (2016-01-22 19:01:56 UTC) #2
brettw
lgtm
4 years, 11 months ago (2016-01-22 21:01:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1617213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1617213003/1
4 years, 11 months ago (2016-01-22 21:24:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 21:35:39 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 21:36:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33ecd69e345149844bef8f1026aebcb5f38afcec
Cr-Commit-Position: refs/heads/master@{#371044}

Powered by Google App Engine
This is Rietveld 408576698