Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 16172007: Show email confirmation for sign in from the hot-dog menu (Closed)

Created:
7 years, 6 months ago by fdoray
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Show email confirmation for sign in from the hot-dog menu BUG=245780 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206231

Patch Set 1 #

Total comments: 2

Patch Set 2 : RedirectToNtpOrAppsPage as standalone function + add missing {} #

Total comments: 2

Patch Set 3 : Upload before commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -27 lines) Patch
M chrome/browser/ui/sync/one_click_signin_helper.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 2 9 chunks +36 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
fdoray
Could you take a look at this CL?
7 years, 6 months ago (2013-06-05 20:37:48 UTC) #1
Roger Tawa OOO till Jul 10th
Salut Francois, You could make RedirectToNtpOrAppsPage() and RedirectToNtpOrAppsPageIfNecessary() standalone functions inside the .cc file in ...
7 years, 6 months ago (2013-06-05 23:48:37 UTC) #2
fdoray
On 2013/06/05 23:48:37, Roger Tawa wrote: > Salut Francois, > > You could make RedirectToNtpOrAppsPage() ...
7 years, 6 months ago (2013-06-10 15:43:57 UTC) #3
fdoray
https://codereview.chromium.org/16172007/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc File chrome/browser/ui/sync/one_click_signin_helper.cc (right): https://codereview.chromium.org/16172007/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc#newcode924 chrome/browser/ui/sync/one_click_signin_helper.cc:924: RedirectToNtpOrAppsPage(); On 2013/06/05 23:48:37, Roger Tawa wrote: > Add ...
7 years, 6 months ago (2013-06-10 15:44:13 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm Thanks Francois.
7 years, 6 months ago (2013-06-10 17:36:21 UTC) #5
noms (inactive)
lgtm
7 years, 6 months ago (2013-06-10 17:41:29 UTC) #6
bcwhite
https://codereview.chromium.org/16172007/diff/5001/chrome/browser/ui/sync/one_click_signin_helper.cc File chrome/browser/ui/sync/one_click_signin_helper.cc (right): https://codereview.chromium.org/16172007/diff/5001/chrome/browser/ui/sync/one_click_signin_helper.cc#newcode1208 chrome/browser/ui/sync/one_click_signin_helper.cc:1208: RedirectToNtpOrAppsPageIfNecessary(web_contents(), source_); This is now a conditional call whereas ...
7 years, 6 months ago (2013-06-11 15:57:02 UTC) #7
fdoray
I answered Brian's question. https://codereview.chromium.org/16172007/diff/5001/chrome/browser/ui/sync/one_click_signin_helper.cc File chrome/browser/ui/sync/one_click_signin_helper.cc (right): https://codereview.chromium.org/16172007/diff/5001/chrome/browser/ui/sync/one_click_signin_helper.cc#newcode1208 chrome/browser/ui/sync/one_click_signin_helper.cc:1208: RedirectToNtpOrAppsPageIfNecessary(web_contents(), source_); On 2013/06/11 15:57:02, ...
7 years, 6 months ago (2013-06-11 16:03:34 UTC) #8
bcwhite
lgtm
7 years, 6 months ago (2013-06-11 17:45:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fdoray@chromium.org/16172007/18001
7 years, 6 months ago (2013-06-13 16:53:14 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=162982
7 years, 6 months ago (2013-06-13 21:46:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fdoray@chromium.org/16172007/18001
7 years, 6 months ago (2013-06-13 22:47:28 UTC) #12
commit-bot: I haz the power
7 years, 6 months ago (2013-06-14 00:02:40 UTC) #13
Message was sent while issue was closed.
Change committed as 206231

Powered by Google App Engine
This is Rietveld 408576698