Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1617143002: Remove "push" button from service worker internals UI. (Closed)

Created:
4 years, 11 months ago by Marijn Kruisselbrink
Modified:
4 years, 11 months ago
Reviewers:
Peter Beverloo, nhiroki
CC:
blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "push" button from service worker internals UI. As suggested in https://codereview.chromium.org/1579413004#msg9 the button isn't really used now devtools has the same functionality, and removing this functionality allows cleaning up the event dispatching code more. BUG=570820 Committed: https://crrev.com/60bde28d2d7372123977d1aba5e4f953eac5d716 Cr-Commit-Position: refs/heads/master@{#370945}

Patch Set 1 #

Messages

Total messages: 9 (3 generated)
Marijn Kruisselbrink
4 years, 11 months ago (2016-01-21 22:56:32 UTC) #2
nhiroki
lgtm
4 years, 11 months ago (2016-01-22 06:00:07 UTC) #3
Peter Beverloo
lgtm, thanks!
4 years, 11 months ago (2016-01-22 10:57:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1617143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1617143002/1
4 years, 11 months ago (2016-01-22 10:58:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 11:44:09 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 11:45:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60bde28d2d7372123977d1aba5e4f953eac5d716
Cr-Commit-Position: refs/heads/master@{#370945}

Powered by Google App Engine
This is Rietveld 408576698