Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1617123002: Generate documentation for enumeration values. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generate documentation for enumeration values. I missed it previous time, now noticed that format.dart does not change when I update the idl.dart file constant operations. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b0704262d9c2c33abc0084dab9e07b3acf541924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -11 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 4 chunks +281 lines, -4 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 4 chunks +16 lines, -6 lines 0 comments Download
M pkg/analyzer/tool/summary/idl_model.dart View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-21 18:54:29 UTC) #1
Paul Berry
lgtm
4 years, 11 months ago (2016-01-21 18:58:00 UTC) #2
scheglov
4 years, 11 months ago (2016-01-21 18:59:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b0704262d9c2c33abc0084dab9e07b3acf541924 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698