tests/compiler/dart2js/js_parser_test.dart - Issue 1617083002: Base JavaScript code position computation on JavaScript tracer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/js_parser_test.dart

Issue 1617083002: Base JavaScript code position computation on JavaScript tracer. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/js_parser_test.dart

diff --git a/tests/compiler/dart2js/js_parser_test.dart b/tests/compiler/dart2js/js_parser_test.dart

index 4022724c3b2ba12805495a0e6c3ca93721f8b038..89d5107070f604e24bde62b2794bfdeacb6994f8 100644

--- a/tests/compiler/dart2js/js_parser_test.dart

+++ b/tests/compiler/dart2js/js_parser_test.dart

@@ -15,7 +15,7 @@ Future testExpression(String expression, [String expect = ""]) {

String jsText =

jsAst.prettyPrint(node,

compiler,

- allowVariableMinification: false).getText();

+ allowVariableMinification: false);

if (expect == "") {

Expect.stringEquals(expression, jsText);

} else {