pkg/compiler/lib/src/js_backend/namer_names.dart - Issue 1617083002: Base JavaScript code position computation on JavaScript tracer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/namer_names.dart

Issue 1617083002: Base JavaScript code position computation on JavaScript tracer. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/namer_names.dart

diff --git a/pkg/compiler/lib/src/js_backend/namer_names.dart b/pkg/compiler/lib/src/js_backend/namer_names.dart

index 60e159745cea7327c9ea61b72e01a83cf0ccd05c..31a17471ca2fe071cce57b6815b38901cda15c54 100644

--- a/pkg/compiler/lib/src/js_backend/namer_names.dart

+++ b/pkg/compiler/lib/src/js_backend/namer_names.dart

@@ -8,7 +8,12 @@ abstract class _NamerName extends jsAst.Name {

int get _kind;

_NamerName get _target => this;

- toString() => throw new UnsupportedError("Cannot convert a name to a string");

+ String toString() {

+ if (DEBUG_MODE) {

+ return 'Name($key)';

+ }

+ throw new UnsupportedError("Cannot convert a name to a string");

+ }

}

enum _NamerNameKinds {