pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart - Issue 1617083002: Base JavaScript code position computation on JavaScript tracer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart

Issue 1617083002: Base JavaScript code position computation on JavaScript tracer. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart b/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart

index 9e81bca631b5918104099b25a6888581e2cce847..65d0519b357cf876b49338421e5249dfa45441a7 100644

--- a/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart

@@ -281,7 +281,7 @@ class ModelEmitter {

isSplit ? buildDeferredInitializerGlobal() : new js.Block.empty(),

code]);

- mainOutput.addBuffer(js.prettyPrint(program, compiler,

+ mainOutput.addBuffer(js.createCodeBuffer(program, compiler,

monitor: compiler.dumpInfoTask));

if (shouldGenerateSourceMap) {

@@ -335,7 +335,7 @@ class ModelEmitter {

buildDeferredInitializerGlobal(),

js.js.statement('$deferredInitializersGlobal.current = #', code)]);

- output.addBuffer(js.prettyPrint(program, compiler,

+ output.addBuffer(js.createCodeBuffer(program, compiler,

monitor: compiler.dumpInfoTask));

// Make a unique hash of the code (before the sourcemaps are added)