Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 1617063003: Ship canvas.toBlob (Closed)

Created:
4 years, 11 months ago by xlai (Olivia)
Modified:
4 years, 11 months ago
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-html_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, Justin Novosad
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship canvas.toBlob With 3 L-g-t-m from the API owners (https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FnZBCN4t46w), this feature is ready to ship. Patches that make corrections based on specification change (https://codereview.chromium.org/1496683005 and https://codereview.chromium.org/1609313002/) have been landed. Also, the concern of having the threaded implementation (as compared to the idle-periods implementation) have been addressed and fixed by using a shared thread pool in Blink (https://code.google.com/p/chromium/issues/detail?id=567887). BUG=67587 Committed: https://crrev.com/79bf7506c54ea3a11b55c39864f816cb16588bf4 Cr-Commit-Position: refs/heads/master@{#371256}

Patch Set 1 : #

Patch Set 2 : Update expected result in property listing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
xlai (Olivia)
Hi Justin, In this week we've landed the patches that address all the critical concerns ...
4 years, 11 months ago (2016-01-22 07:13:40 UTC) #4
Justin Novosad
w00t! We just branched off M49, so the timing is good. For clarity, please rename ...
4 years, 11 months ago (2016-01-22 15:48:44 UTC) #6
chrishtr
lgtm
4 years, 11 months ago (2016-01-22 16:48:45 UTC) #7
Rick Byers
Also LGTM
4 years, 11 months ago (2016-01-22 17:09:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1617063003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1617063003/20001
4 years, 11 months ago (2016-01-22 19:43:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1617063003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1617063003/60001
4 years, 11 months ago (2016-01-25 15:17:46 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 11 months ago (2016-01-25 17:35:13 UTC) #18
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 17:36:22 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/79bf7506c54ea3a11b55c39864f816cb16588bf4
Cr-Commit-Position: refs/heads/master@{#371256}

Powered by Google App Engine
This is Rietveld 408576698