Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 161703002: Add more timezones to the tz selection UI (Closed)

Created:
6 years, 10 months ago by jungshik at Google
Modified:
6 years, 10 months ago
CC:
jsalz, chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Add new timezone entries to the tz selection UI Add Reykjavik, Oslo, Lisbon, Bucharest, Budapest, Ho Chi Minh, etc. BUG=chrome-os-partner:23902 TEST=Added timezones show up in the zone selection menu. TBR=satorux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251198

Patch Set 1 #

Patch Set 2 : re-upload to get codereview happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M chromeos/settings/timezone_settings.cc View 4 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
jungshik at Google
Nikita, can you take a look? Thanks
6 years, 10 months ago (2014-02-12 22:44:26 UTC) #1
jsalz
Confirmed that this is a sufficient list for chrome-os-partner:23902 Thanks Jungshik!
6 years, 10 months ago (2014-02-13 04:29:16 UTC) #2
Nikita (slow)
lgtm
6 years, 10 months ago (2014-02-13 10:50:24 UTC) #3
jungshik at Google
The CQ bit was checked by jshin@chromium.org
6 years, 10 months ago (2014-02-13 18:39:25 UTC) #4
jungshik at Google
satorux@chromium.org: Please approve the change. Thanks.
6 years, 10 months ago (2014-02-13 18:40:00 UTC) #5
jungshik at Google
The CQ bit was unchecked by jshin@chromium.org
6 years, 10 months ago (2014-02-13 18:40:09 UTC) #6
jungshik at Google
On 2014/02/13 18:40:00, Jungshik Shin wrote: > satorux@chromium.org: Please approve the change. Thanks. Well, I'll ...
6 years, 10 months ago (2014-02-13 18:41:06 UTC) #7
jungshik at Google
The CQ bit was checked by jshin@chromium.org
6 years, 10 months ago (2014-02-13 18:41:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/161703002/30001
6 years, 10 months ago (2014-02-13 18:43:08 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 19:29:04 UTC) #10
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=149734
6 years, 10 months ago (2014-02-13 19:29:05 UTC) #11
jungshik at Google
The CQ bit was checked by jshin@chromium.org
6 years, 10 months ago (2014-02-13 21:43:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/161703002/30001
6 years, 10 months ago (2014-02-13 21:49:04 UTC) #13
commit-bot: I haz the power
Change committed as 251198
6 years, 10 months ago (2014-02-14 00:12:40 UTC) #14
satorux1
6 years, 10 months ago (2014-02-17 03:46:27 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698