[wasm] Add utilities to print out WASM ast directly from the bytes.

[wasm] Add utilities to print out WASM ast directly from the bytes.

Motivated by finding a bug in a larger module, this CL adds the ability
to dump out a byte-by-byte, nested view of the decoded AST. This
byte-by-byte output uses the opcode enum to make it readable, but is
suitable for pasting into a byte[] in C or JS and thus making a regression
test.

Also fix a bug; the case of running out of registers for indirect calls.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/3b6b8119ffc9fcd8f1946697140e9e333ceb61ad
Cr-Commit-Position: refs/heads/master@{#33442}

[ahaas, 2016-01-21 15:47:28]

lgtm

https://codereview.chromium.org/1616973004/diff/1/test/cctest/wasm/wasm-run-u...
File test/cctest/wasm/wasm-run-utils.h (right):

https://codereview.chromium.org/1616973004/diff/1/test/cctest/wasm/wasm-run-u...
test/cctest/wasm/wasm-run-utils.h:171: void AddIndirectFunctionTable(int*
functions, int table_size) {
This function is only used with the parameters "null_ptr, 0". Do you plan to use
it for more tests? If not, then imo the code should not be more complex than
necessary.

https://codereview.chromium.org/1616973004/diff/1/test/cctest/wasm/wasm-run-u...
test/cctest/wasm/wasm-run-utils.h:183: void PopulateIndirectFunctionTable() {
This function is not used anywhere. Does it have to be in this CL?

[titzer, 2016-01-21 15:50:09]

On 2016/01/21 15:47:28, ahaas wrote:
> lgtm
> 
>
https://codereview.chromium.org/1616973004/diff/1/test/cctest/wasm/wasm-run-u...
> File test/cctest/wasm/wasm-run-utils.h (right):
> 
>
https://codereview.chromium.org/1616973004/diff/1/test/cctest/wasm/wasm-run-u...
> test/cctest/wasm/wasm-run-utils.h:171: void AddIndirectFunctionTable(int*
> functions, int table_size) {
> This function is only used with the parameters "null_ptr, 0". Do you plan to
use
> it for more tests? If not, then imo the code should not be more complex than
> necessary.

Yes, I've just cleaned up the other places where this was happening manually.

> 
>
https://codereview.chromium.org/1616973004/diff/1/test/cctest/wasm/wasm-run-u...
> test/cctest/wasm/wasm-run-utils.h:183: void PopulateIndirectFunctionTable() {
> This function is not used anywhere. Does it have to be in this CL?

It is used now :-)

[ahaas, 2016-01-21 15:52:02]

lgtm

[titzer, 2016-01-21 16:09:28]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2016-01-21 16:09:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616973004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616973004/20001

[commit-bot: I haz the power, 2016-01-21 16:10:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-21 16:11:23]

Description was changed from

==========
[wasm] Add utilities to print out WASM ast directly from the bytes.

Motivated by finding a bug in a larger module, this CL adds the ability
to dump out a byte-by-byte, nested view of the decoded AST. This
byte-by-byte output uses the opcode enum to make it readable, but is
suitable for pasting into a byte[] in C or JS and thus making a regression
test.

Also fix a bug; the case of running out of registers for indirect calls.

R=ahaas@chromium.org
BUG=
==========

to

==========
[wasm] Add utilities to print out WASM ast directly from the bytes.

Motivated by finding a bug in a larger module, this CL adds the ability
to dump out a byte-by-byte, nested view of the decoded AST. This
byte-by-byte output uses the opcode enum to make it readable, but is
suitable for pasting into a byte[] in C or JS and thus making a regression
test.

Also fix a bug; the case of running out of registers for indirect calls.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/3b6b8119ffc9fcd8f1946697140e9e333ceb61ad
Cr-Commit-Position: refs/heads/master@{#33442}
==========

[commit-bot: I haz the power, 2016-01-21 16:11:24]

Patchset 2 (id:??) landed as
https://crrev.com/3b6b8119ffc9fcd8f1946697140e9e333ceb61ad
Cr-Commit-Position: refs/heads/master@{#33442}