Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: lib/src/observable_box.dart

Issue 1616953004: Fixed strong mode errors and warnings reachable from lib/observe.dart (Closed) Base URL: https://github.com/dart-lang/observe.git@master
Patch Set: Reformat Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/observable_box.dart
diff --git a/lib/src/observable_box.dart b/lib/src/observable_box.dart
index dfaf7ffb5960607615aa851acea920d9a125115c..af8df81e888a9363bad704f09308fec608b91854 100644
--- a/lib/src/observable_box.dart
+++ b/lib/src/observable_box.dart
@@ -20,7 +20,7 @@ class ObservableBox<T> extends ChangeNotifier {
@reflectable T get value => _value;
@reflectable void set value(T newValue) {
- _value = notifyPropertyChange(#value, _value, newValue);
+ _value = notifyPropertyChange(#value, _value, newValue) as T;
vsm 2016/01/22 16:47:15 Another cast from dynamic.
Jennifer Messerly 2016/01/22 17:45:00 this one too could be either generic method for no
vsm 2016/01/22 18:49:22 Done.
}
String toString() => '#<$runtimeType value: $value>';

Powered by Google App Engine
This is Rietveld 408576698