Fix division by zero. Test filter with empty output.

Fix division by zero. Test filter with empty output.

BUG=579672
Committed: https://crrev.com/b266c8153a66f01644f3361fe9cc7d439df1e981
Cr-Commit-Position: refs/heads/master@{#370675}

[eustas, 2016-01-21 09:28:39]

eustas@chromium.org changed reviewers:
+ cbentzel@chromium.org

[eustas, 2016-01-21 09:29:10]

eustas@chromium.org changed reviewers:
+ rtenneti@chromium.org

[cbentzel, 2016-01-21 10:42:59]

https://codereview.chromium.org/1616863002/diff/1/net/filter/brotli_filter_un...
File net/filter/brotli_filter_unittest.cc (right):

https://codereview.chromium.org/1616863002/diff/1/net/filter/brotli_filter_un...
net/filter/brotli_filter_unittest.cc:160: filter_.reset(nullptr);
Why is this needed? Shouldn't the scoped_ptr be going out of scope when the test
destroys?

[eustas, 2016-01-21 10:49:14]

https://codereview.chromium.org/1616863002/diff/1/net/filter/brotli_filter_un...
File net/filter/brotli_filter_unittest.cc (right):

https://codereview.chromium.org/1616863002/diff/1/net/filter/brotli_filter_un...
net/filter/brotli_filter_unittest.cc:160: filter_.reset(nullptr);
On 2016/01/21 10:42:59, cbentzel wrote:
> Why is this needed? Shouldn't the scoped_ptr be going out of scope when the
test
> destroys?

It is for making destruction an explicit part of test. Of course this could be
easily removed, but in the case of problems stack trace will look a little bit
weird.

[cbentzel, 2016-01-21 10:57:58]

On 2016/01/21 10:49:14, eustas wrote:
>
https://codereview.chromium.org/1616863002/diff/1/net/filter/brotli_filter_un...
> File net/filter/brotli_filter_unittest.cc (right):
> 
>
https://codereview.chromium.org/1616863002/diff/1/net/filter/brotli_filter_un...
> net/filter/brotli_filter_unittest.cc:160: filter_.reset(nullptr);
> On 2016/01/21 10:42:59, cbentzel wrote:
> > Why is this needed? Shouldn't the scoped_ptr be going out of scope when the
> test
> > destroys?
> 
> It is for making destruction an explicit part of test. Of course this could be
> easily removed, but in the case of problems stack trace will look a little bit
> weird.

Was destruction not happening before? If it was happening, I would suggest
removing this.

[eustas, 2016-01-21 11:06:23]

On 2016/01/21 10:57:58, cbentzel wrote:
> On 2016/01/21 10:49:14, eustas wrote:
> >
>
https://codereview.chromium.org/1616863002/diff/1/net/filter/brotli_filter_un...
> > File net/filter/brotli_filter_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/1616863002/diff/1/net/filter/brotli_filter_un...
> > net/filter/brotli_filter_unittest.cc:160: filter_.reset(nullptr);
> > On 2016/01/21 10:42:59, cbentzel wrote:
> > > Why is this needed? Shouldn't the scoped_ptr be going out of scope when
the
> > test
> > > destroys?
> > 
> > It is for making destruction an explicit part of test. Of course this could
be
> > easily removed, but in the case of problems stack trace will look a little
bit
> > weird.
> 
> Was destruction not happening before? If it was happening, I would suggest
> removing this.

Fixed

[cbentzel, 2016-01-21 11:07:28]

LGTM

[eustas, 2016-01-21 11:07:46]

The CQ bit was checked by eustas@chromium.org

[commit-bot: I haz the power, 2016-01-21 11:08:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616863002/20001

[commit-bot: I haz the power, 2016-01-21 12:31:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-21 12:32:10]

Description was changed from

==========
Fix division by zero. Test filter with empty output.

BUG=579672
==========

to

==========
Fix division by zero. Test filter with empty output.

BUG=579672

Committed: https://crrev.com/b266c8153a66f01644f3361fe9cc7d439df1e981
Cr-Commit-Position: refs/heads/master@{#370675}
==========

[commit-bot: I haz the power, 2016-01-21 12:32:11]

Patchset 2 (id:??) landed as
https://crrev.com/b266c8153a66f01644f3361fe9cc7d439df1e981
Cr-Commit-Position: refs/heads/master@{#370675}