third_party/WebKit/Source/web/mac/WebSubstringUtil.mm - Issue 1616813002: Consider Zoom factor when getting bounding rect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

Issue 1616813002: Consider Zoom factor when getting bounding rect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a test. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

diff --git a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

index 350e9cb072ff92136e107450e6ab66a12decc15d..8c626cc5e1af784eb0fb0e02466ef437dd47fb95 100644

--- a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

+++ b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

@@ -113,7 +113,9 @@ WebPoint getBaselinePoint(FrameView* frameView, const EphemeralRange& range, NSA

{

// Compute bottom left corner and convert to AppKit coordinates.

// TODO(yosin) We shold avoid to create |Range| object. See crbug.com/529985.

- IntRect stringRect = enclosingIntRect(createRange(range)->boundingRect());

+ IntRect stringRect = frameView->contentsToRootFrame(createRange(range)->boundingBox());

+ printf("=====stringRect: %d,%d,%d,%d\n", stringRect.x(), stringRect.y(),

+ stringRect.width(), stringRect.height());

IntPoint stringPoint = stringRect.minXMaxYCorner();

stringPoint.setY(frameView->height() - stringPoint.y());