Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

Issue 1616813002: Consider Zoom factor when getting bounding rect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
diff --git a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
index 350e9cb072ff92136e107450e6ab66a12decc15d..ab00dbecdf277007340030e0528374a2f53111dd 100644
--- a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
+++ b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
@@ -113,7 +113,13 @@ WebPoint getBaselinePoint(FrameView* frameView, const EphemeralRange& range, NSA
{
// Compute bottom left corner and convert to AppKit coordinates.
// TODO(yosin) We shold avoid to create |Range| object. See crbug.com/529985.
- IntRect stringRect = enclosingIntRect(createRange(range)->boundingRect());
+ float scale = frameView->frame().pageZoomFactor() * frameView->frame().textZoomFactor();
yosin_UTC9 2016/01/26 03:44:17 Which coordinate space do you want to get? See htt
Shu Chen 2016/01/26 13:06:43 Done. Will the new change work?
+ FloatRect rect = createRange(range)->boundingRect();
+ rect.setX(rect.x() * scale);
+ rect.setY(rect.y() * scale);
+ rect.setWidth(rect.width() * scale);
+ rect.setHeight(rect.height() * scale);
+ IntRect stringRect = enclosingIntRect(rect);
IntPoint stringPoint = stringRect.minXMaxYCorner();
stringPoint.setY(frameView->height() - stringPoint.y());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698