Oilpan: LinkLoaderClient must be a GC mixin.

Oilpan: LinkLoaderClient must be a GC mixin.

LinkLoader notifies its 'client' of load completion and other lifecycle
transitions. The assumption is that the client's lifetime is >= that
of the loader object, hence a bare pointer is all required.

This assumption doesn't hold when both LinkLoader and the client is on
the Oilpan heap, nor when LinkLoader is on the heap and the client is
stack allocated (cf. mock client object in LinkLoader unit tests).

Address the unsoundness by making LinkLoaderClient a GC mixin.

TBR=haraken@chromium.org
BUG=

Committed: https://crrev.com/6e6d363a6cf3afc0d4c791fb5689877540c1b222
Cr-Commit-Position: refs/heads/master@{#370654}

[sof, 2016-01-21 08:03:22]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 08:03:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616713003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616713003/1

[sof, 2016-01-21 08:09:05]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-01-21 08:09:06]

please take a look.

WebKit unit tests are now failing,
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan....

Not a regression per se, but a latent problem that was just now brought to the
fore due to GC timing changes.

[sof, 2016-01-21 08:27:56]

I think it would be worthwhile to review all the *Client interfaces, to verify
that all bare pointers kept for those are properly handled when the object
implementing the client interface is on the heap.

[commit-bot: I haz the power, 2016-01-21 09:17:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 09:17:13]

Dry run: This issue passed the CQ dry run.

[sof, 2016-01-21 09:30:40]

Description was changed from

==========
Oilpan: LinkLoaderClient must be a GC mixin.

LinkLoader notifies its 'client' of load completion and other lifecycle
transitions. The assumption is that the client's lifetime is >= that
of the loader object, hence a bare pointer is all required.

This assumption doesn't hold when both LinkLoader and the client is on
the Oilpan heap, nor when LinkLoader is on the heap and the client is
stack allocated (cf. mock client object in LinkLoader unit tests).

Address the unsoundness by making LinkLoaderClient a GC mixin.

R=
BUG=
==========

to

==========
Oilpan: LinkLoaderClient must be a GC mixin.

LinkLoader notifies its 'client' of load completion and other lifecycle
transitions. The assumption is that the client's lifetime is >= that
of the loader object, hence a bare pointer is all required.

This assumption doesn't hold when both LinkLoader and the client is on
the Oilpan heap, nor when LinkLoader is on the heap and the client is
stack allocated (cf. mock client object in LinkLoader unit tests).

Address the unsoundness by making LinkLoaderClient a GC mixin.

TBR=haraken@chromium.org
BUG=
==========

[sof, 2016-01-21 09:32:27]

TBRing against haraken@ so as to unbreak the unit tests.

[sof, 2016-01-21 09:32:40]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-01-21 09:33:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616713003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616713003/1

[commit-bot: I haz the power, 2016-01-21 09:38:18]

Description was changed from

==========
Oilpan: LinkLoaderClient must be a GC mixin.

LinkLoader notifies its 'client' of load completion and other lifecycle
transitions. The assumption is that the client's lifetime is >= that
of the loader object, hence a bare pointer is all required.

This assumption doesn't hold when both LinkLoader and the client is on
the Oilpan heap, nor when LinkLoader is on the heap and the client is
stack allocated (cf. mock client object in LinkLoader unit tests).

Address the unsoundness by making LinkLoaderClient a GC mixin.

TBR=haraken@chromium.org
BUG=
==========

to

==========
Oilpan: LinkLoaderClient must be a GC mixin.

LinkLoader notifies its 'client' of load completion and other lifecycle
transitions. The assumption is that the client's lifetime is >= that
of the loader object, hence a bare pointer is all required.

This assumption doesn't hold when both LinkLoader and the client is on
the Oilpan heap, nor when LinkLoader is on the heap and the client is
stack allocated (cf. mock client object in LinkLoader unit tests).

Address the unsoundness by making LinkLoaderClient a GC mixin.

TBR=haraken@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-01-21 09:38:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-21 09:39:20]

Description was changed from

==========
Oilpan: LinkLoaderClient must be a GC mixin.

LinkLoader notifies its 'client' of load completion and other lifecycle
transitions. The assumption is that the client's lifetime is >= that
of the loader object, hence a bare pointer is all required.

This assumption doesn't hold when both LinkLoader and the client is on
the Oilpan heap, nor when LinkLoader is on the heap and the client is
stack allocated (cf. mock client object in LinkLoader unit tests).

Address the unsoundness by making LinkLoaderClient a GC mixin.

TBR=haraken@chromium.org
BUG=
==========

to

==========
Oilpan: LinkLoaderClient must be a GC mixin.

LinkLoader notifies its 'client' of load completion and other lifecycle
transitions. The assumption is that the client's lifetime is >= that
of the loader object, hence a bare pointer is all required.

This assumption doesn't hold when both LinkLoader and the client is on
the Oilpan heap, nor when LinkLoader is on the heap and the client is
stack allocated (cf. mock client object in LinkLoader unit tests).

Address the unsoundness by making LinkLoaderClient a GC mixin.

TBR=haraken@chromium.org
BUG=

Committed: https://crrev.com/6e6d363a6cf3afc0d4c791fb5689877540c1b222
Cr-Commit-Position: refs/heads/master@{#370654}
==========

[commit-bot: I haz the power, 2016-01-21 09:39:20]

Patchset 1 (id:??) landed as
https://crrev.com/6e6d363a6cf3afc0d4c791fb5689877540c1b222
Cr-Commit-Position: refs/heads/master@{#370654}

[haraken, 2016-01-21 09:58:33]

LGTM